Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java

Issue 1959043002: Fix warning when closing a proxy that passed its handle. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
index 38d8114fc1ccb47a5e0dac12d31c5a1e7d313efd..f1d892d2e37ae740dc7a9e09c53ace967bd19f36 100644
--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
+++ b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
@@ -17,9 +17,12 @@ import java.io.Closeable;
* Base class for mojo generated interfaces.
*/
public interface Interface extends ConnectionErrorHandler, Closeable {
-
/**
- * The close method is called when the connection to the interface is closed.
+ * If the interface is an implementation, the close method is called when the connection to the
+ * implementation is closed.
+ * <p>
+ * If the interface is a proxy, the close method closes the connection to the implementation.
+ * This method must be called before the proxy is released.
*
* @see java.io.Closeable#close()
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698