Eagerly remove disposed DOMTimers as observers.

Eagerly remove disposed DOMTimers as observers.

Once the coordinator lets go of a timer, no need to keep it
around as an observer of the ExecutionContext.

R=
BUG=

Committed: https://crrev.com/0a297738301705d02f57968334bd6f7c7dc95f4c
Cr-Commit-Position: refs/heads/master@{#392309}

[sof, 2016-05-09 12:31:00]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-05-09 12:31:00]

please take a look.

A bit related to issue 597953. I'm seeing larger hash tables building up for
ContextLifecycleObservers. This helps keep the growth down.

[keishi, 2016-05-09 12:34:31]

keishi@chromium.org changed reviewers:
+ keishi@chromium.org

[keishi, 2016-05-09 12:34:31]

LGTM

[sof, 2016-05-09 12:42:32]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-09 12:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959013002/1

[sof, 2016-05-09 12:43:52]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2016-05-09 12:44:51]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-09 12:45:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959013002/1

[haraken, 2016-05-09 13:27:53]

LGTM

[commit-bot: I haz the power, 2016-05-09 13:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 13:32:55]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sof, 2016-05-09 13:40:43]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-09 13:40:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959013002/1

[commit-bot: I haz the power, 2016-05-09 14:19:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-09 14:23:43]

Description was changed from

==========
Eagerly remove disposed DOMTimers as observers.

Once the coordinator lets go of a timer, no need to keep it
around as an observer of the ExecutionContext.

R=
BUG=
==========

to

==========
Eagerly remove disposed DOMTimers as observers.

Once the coordinator lets go of a timer, no need to keep it
around as an observer of the ExecutionContext.

R=
BUG=

Committed: https://crrev.com/0a297738301705d02f57968334bd6f7c7dc95f4c
Cr-Commit-Position: refs/heads/master@{#392309}
==========

[commit-bot: I haz the power, 2016-05-09 14:23:44]

Patchset 1 (id:??) landed as
https://crrev.com/0a297738301705d02f57968334bd6f7c7dc95f4c
Cr-Commit-Position: refs/heads/master@{#392309}

[sof, 2016-05-11 11:24:23]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1968963002/ by sigbjornf@opera.com.

The reason for reverting is: Caused issue 610606, reverting to locally
investigate how/why..

[sof, 2016-05-11 12:00:24]

On 2016/05/11 11:24:23, sof wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1968963002/ by mailto:sigbjornf@opera.com.
> 
> The reason for reverting is: Caused issue 610606, reverting to locally
> investigate how/why..

I see the problem now..and really should have before making the original change.
Will followup with an adjusted CL, as I do think it is worth being eager about
un-observing all these timers.