Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Unified Diff: base/task_scheduler/scheduler_thread_pool_impl.h

Issue 1958973003: Revert of Name TaskScheduler's worker threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b7_fdoray_fixtracing
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/task_scheduler/scheduler_thread_pool_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_thread_pool_impl.h
diff --git a/base/task_scheduler/scheduler_thread_pool_impl.h b/base/task_scheduler/scheduler_thread_pool_impl.h
index 1c1f1869e4f4658c3292f3893e4c85663470a9df..06812c79cae28d4419cf6425d0aca94f60a32f59 100644
--- a/base/task_scheduler/scheduler_thread_pool_impl.h
+++ b/base/task_scheduler/scheduler_thread_pool_impl.h
@@ -8,7 +8,6 @@
#include <stddef.h>
#include <memory>
-#include <string>
#include <vector>
#include "base/base_export.h"
@@ -16,7 +15,6 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "base/strings/string_piece.h"
#include "base/synchronization/condition_variable.h"
#include "base/task_runner.h"
#include "base/task_scheduler/priority_queue.h"
@@ -52,16 +50,15 @@
// destroyed after JoinForTesting() has returned.
~SchedulerThreadPoolImpl() override;
- // Creates a SchedulerThreadPool labeled |name| with up to |max_threads|
- // threads of priority |thread_priority|. |io_restriction| indicates whether
- // Tasks on the constructed thread pool are allowed to make I/O calls.
+ // Creates a SchedulerThreadPool with up to |max_threads| threads of priority
+ // |thread_priority|. |io_restriction| indicates whether Tasks on the
+ // constructed thread pool are allowed to make I/O calls.
// |re_enqueue_sequence_callback| will be invoked after a thread of this
// thread pool tries to run a Task. |task_tracker| is used to handle shutdown
// behavior of Tasks. |delayed_task_manager| handles Tasks posted with a
// delay. Returns nullptr on failure to create a thread pool with at least one
// thread.
static std::unique_ptr<SchedulerThreadPoolImpl> Create(
- StringPiece name,
ThreadPriority thread_priority,
size_t max_threads,
IORestriction io_restriction,
@@ -92,8 +89,7 @@
private:
class SchedulerWorkerThreadDelegateImpl;
- SchedulerThreadPoolImpl(StringPiece name,
- IORestriction io_restriction,
+ SchedulerThreadPoolImpl(IORestriction io_restriction,
TaskTracker* task_tracker,
DelayedTaskManager* delayed_task_manager);
@@ -110,9 +106,6 @@
// Removes |worker_thread| from |idle_worker_threads_stack_|.
void RemoveFromIdleWorkerThreadsStack(SchedulerWorkerThread* worker_thread);
-
- // The name of this thread pool, used to label its worker threads.
- const std::string name_;
// All worker threads owned by this thread pool. Only modified during
// initialization of the thread pool.
« no previous file with comments | « no previous file | base/task_scheduler/scheduler_thread_pool_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698