Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: base/task_scheduler/scheduler_thread_pool_impl.h

Issue 1958973003: Revert of Name TaskScheduler's worker threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b7_fdoray_fixtracing
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/task_scheduler/scheduler_thread_pool_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_IMPL_H_ 5 #ifndef BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_IMPL_H_
6 #define BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_IMPL_H_ 6 #define BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
11 #include <string>
12 #include <vector> 11 #include <vector>
13 12
14 #include "base/base_export.h" 13 #include "base/base_export.h"
15 #include "base/callback.h" 14 #include "base/callback.h"
16 #include "base/logging.h" 15 #include "base/logging.h"
17 #include "base/macros.h" 16 #include "base/macros.h"
18 #include "base/memory/ref_counted.h" 17 #include "base/memory/ref_counted.h"
19 #include "base/strings/string_piece.h"
20 #include "base/synchronization/condition_variable.h" 18 #include "base/synchronization/condition_variable.h"
21 #include "base/task_runner.h" 19 #include "base/task_runner.h"
22 #include "base/task_scheduler/priority_queue.h" 20 #include "base/task_scheduler/priority_queue.h"
23 #include "base/task_scheduler/scheduler_lock.h" 21 #include "base/task_scheduler/scheduler_lock.h"
24 #include "base/task_scheduler/scheduler_thread_pool.h" 22 #include "base/task_scheduler/scheduler_thread_pool.h"
25 #include "base/task_scheduler/scheduler_worker_thread.h" 23 #include "base/task_scheduler/scheduler_worker_thread.h"
26 #include "base/task_scheduler/scheduler_worker_thread_stack.h" 24 #include "base/task_scheduler/scheduler_worker_thread_stack.h"
27 #include "base/task_scheduler/sequence.h" 25 #include "base/task_scheduler/sequence.h"
28 #include "base/task_scheduler/task.h" 26 #include "base/task_scheduler/task.h"
29 #include "base/task_scheduler/task_traits.h" 27 #include "base/task_scheduler/task_traits.h"
(...skipping 15 matching lines...) Expand all
45 43
46 // Callback invoked when a Sequence isn't empty after a worker thread pops a 44 // Callback invoked when a Sequence isn't empty after a worker thread pops a
47 // Task from it. 45 // Task from it.
48 using ReEnqueueSequenceCallback = Callback<void(scoped_refptr<Sequence>)>; 46 using ReEnqueueSequenceCallback = Callback<void(scoped_refptr<Sequence>)>;
49 47
50 // Destroying a SchedulerThreadPool returned by CreateThreadPool() is not 48 // Destroying a SchedulerThreadPool returned by CreateThreadPool() is not
51 // allowed in production; it is always leaked. In tests, it can only be 49 // allowed in production; it is always leaked. In tests, it can only be
52 // destroyed after JoinForTesting() has returned. 50 // destroyed after JoinForTesting() has returned.
53 ~SchedulerThreadPoolImpl() override; 51 ~SchedulerThreadPoolImpl() override;
54 52
55 // Creates a SchedulerThreadPool labeled |name| with up to |max_threads| 53 // Creates a SchedulerThreadPool with up to |max_threads| threads of priority
56 // threads of priority |thread_priority|. |io_restriction| indicates whether 54 // |thread_priority|. |io_restriction| indicates whether Tasks on the
57 // Tasks on the constructed thread pool are allowed to make I/O calls. 55 // constructed thread pool are allowed to make I/O calls.
58 // |re_enqueue_sequence_callback| will be invoked after a thread of this 56 // |re_enqueue_sequence_callback| will be invoked after a thread of this
59 // thread pool tries to run a Task. |task_tracker| is used to handle shutdown 57 // thread pool tries to run a Task. |task_tracker| is used to handle shutdown
60 // behavior of Tasks. |delayed_task_manager| handles Tasks posted with a 58 // behavior of Tasks. |delayed_task_manager| handles Tasks posted with a
61 // delay. Returns nullptr on failure to create a thread pool with at least one 59 // delay. Returns nullptr on failure to create a thread pool with at least one
62 // thread. 60 // thread.
63 static std::unique_ptr<SchedulerThreadPoolImpl> Create( 61 static std::unique_ptr<SchedulerThreadPoolImpl> Create(
64 StringPiece name,
65 ThreadPriority thread_priority, 62 ThreadPriority thread_priority,
66 size_t max_threads, 63 size_t max_threads,
67 IORestriction io_restriction, 64 IORestriction io_restriction,
68 const ReEnqueueSequenceCallback& re_enqueue_sequence_callback, 65 const ReEnqueueSequenceCallback& re_enqueue_sequence_callback,
69 TaskTracker* task_tracker, 66 TaskTracker* task_tracker,
70 DelayedTaskManager* delayed_task_manager); 67 DelayedTaskManager* delayed_task_manager);
71 68
72 // Waits until all threads are idle. 69 // Waits until all threads are idle.
73 void WaitForAllWorkerThreadsIdleForTesting(); 70 void WaitForAllWorkerThreadsIdleForTesting();
74 71
(...skipping 10 matching lines...) Expand all
85 bool PostTaskWithSequence(std::unique_ptr<Task> task, 82 bool PostTaskWithSequence(std::unique_ptr<Task> task,
86 scoped_refptr<Sequence> sequence, 83 scoped_refptr<Sequence> sequence,
87 SchedulerWorkerThread* worker_thread) override; 84 SchedulerWorkerThread* worker_thread) override;
88 void PostTaskWithSequenceNow(std::unique_ptr<Task> task, 85 void PostTaskWithSequenceNow(std::unique_ptr<Task> task,
89 scoped_refptr<Sequence> sequence, 86 scoped_refptr<Sequence> sequence,
90 SchedulerWorkerThread* worker_thread) override; 87 SchedulerWorkerThread* worker_thread) override;
91 88
92 private: 89 private:
93 class SchedulerWorkerThreadDelegateImpl; 90 class SchedulerWorkerThreadDelegateImpl;
94 91
95 SchedulerThreadPoolImpl(StringPiece name, 92 SchedulerThreadPoolImpl(IORestriction io_restriction,
96 IORestriction io_restriction,
97 TaskTracker* task_tracker, 93 TaskTracker* task_tracker,
98 DelayedTaskManager* delayed_task_manager); 94 DelayedTaskManager* delayed_task_manager);
99 95
100 bool Initialize( 96 bool Initialize(
101 ThreadPriority thread_priority, 97 ThreadPriority thread_priority,
102 size_t max_threads, 98 size_t max_threads,
103 const ReEnqueueSequenceCallback& re_enqueue_sequence_callback); 99 const ReEnqueueSequenceCallback& re_enqueue_sequence_callback);
104 100
105 // Wakes up the last thread from this thread pool to go idle, if any. 101 // Wakes up the last thread from this thread pool to go idle, if any.
106 void WakeUpOneThread(); 102 void WakeUpOneThread();
107 103
108 // Adds |worker_thread| to |idle_worker_threads_stack_|. 104 // Adds |worker_thread| to |idle_worker_threads_stack_|.
109 void AddToIdleWorkerThreadsStack(SchedulerWorkerThread* worker_thread); 105 void AddToIdleWorkerThreadsStack(SchedulerWorkerThread* worker_thread);
110 106
111 // Removes |worker_thread| from |idle_worker_threads_stack_|. 107 // Removes |worker_thread| from |idle_worker_threads_stack_|.
112 void RemoveFromIdleWorkerThreadsStack(SchedulerWorkerThread* worker_thread); 108 void RemoveFromIdleWorkerThreadsStack(SchedulerWorkerThread* worker_thread);
113 109
114 // The name of this thread pool, used to label its worker threads.
115 const std::string name_;
116
117 // All worker threads owned by this thread pool. Only modified during 110 // All worker threads owned by this thread pool. Only modified during
118 // initialization of the thread pool. 111 // initialization of the thread pool.
119 std::vector<std::unique_ptr<SchedulerWorkerThread>> worker_threads_; 112 std::vector<std::unique_ptr<SchedulerWorkerThread>> worker_threads_;
120 113
121 // Synchronizes access to |next_worker_thread_index_|. 114 // Synchronizes access to |next_worker_thread_index_|.
122 SchedulerLock next_worker_thread_index_lock_; 115 SchedulerLock next_worker_thread_index_lock_;
123 116
124 // Index of the worker thread that will be assigned to the next single- 117 // Index of the worker thread that will be assigned to the next single-
125 // threaded TaskRunner returned by this pool. 118 // threaded TaskRunner returned by this pool.
126 size_t next_worker_thread_index_ = 0; 119 size_t next_worker_thread_index_ = 0;
(...skipping 28 matching lines...) Expand all
155 TaskTracker* const task_tracker_; 148 TaskTracker* const task_tracker_;
156 DelayedTaskManager* const delayed_task_manager_; 149 DelayedTaskManager* const delayed_task_manager_;
157 150
158 DISALLOW_COPY_AND_ASSIGN(SchedulerThreadPoolImpl); 151 DISALLOW_COPY_AND_ASSIGN(SchedulerThreadPoolImpl);
159 }; 152 };
160 153
161 } // namespace internal 154 } // namespace internal
162 } // namespace base 155 } // namespace base
163 156
164 #endif // BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_IMPL_H_ 157 #endif // BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | base/task_scheduler/scheduler_thread_pool_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698