Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 1958883003: Revert of binding: Makes Window/Location's attributes accessor-type properties. (Closed)

Created:
4 years, 7 months ago by Yuki
Modified:
4 years, 7 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of binding: Makes Window/Location's attributes accessor-type properties. (patchset #27 id:520001 of https://codereview.chromium.org/1380503002/ ) Reason for revert: We hit a (huge) performance regression. See http://crbug.com/608475 . Original issue's description: > binding: Makes Window/Location's attributes accessor-type properties. > > Makes almost all the attributes (except for cross-origin accessible > attributes) accessor-type properties. The target attributes in this > CL are DOM attributes of Window, Location and workers not annotated > as [DoNotCheckSecurity], which are cross-origin accessible. > > BUG=43394, 516274 > > Committed: https://crrev.com/9ac1750adf85027985c7af3468e0b972c2086235 > Cr-Commit-Position: refs/heads/master@{#390893} TBR=tkent@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=43394, 516274 Committed: https://crrev.com/0e0d4e2542246e3a53e070aaf82e7570a145bc2a Cr-Commit-Position: refs/heads/master@{#392315}

Patch Set 1 #

Patch Set 2 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -770 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/replaceable.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/replaceable-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/lenient-this.html View 1 1 chunk +1 line, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/dom/location-stringify.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-access-over-property-descriptor.html View 1 chunk +18 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-access-over-property-descriptor-expected.txt View 1 chunk +6 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-properties-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/IndexedDB/interfaces-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/browsers/the-window-object/window-properties-expected.txt View 1 1 chunk +93 lines, -93 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/idlharness-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 5 chunks +134 lines, -249 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 5 chunks +139 lines, -257 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/idl_types.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 1 6 chunks +9 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 1 4 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 8 chunks +47 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yuki
Created Revert of binding: Makes Window/Location's attributes accessor-type properties.
4 years, 7 months ago (2016-05-09 06:43:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958883003/1
4 years, 7 months ago (2016-05-09 06:43:35 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/2274)
4 years, 7 months ago (2016-05-09 06:45:46 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-09 06:48:09 UTC) #5
tkent
lgtm
4 years, 7 months ago (2016-05-09 07:45:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958883003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958883003/300001
4 years, 7 months ago (2016-05-09 13:28:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:300001)
4 years, 7 months ago (2016-05-09 14:54:06 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 14:55:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e0d4e2542246e3a53e070aaf82e7570a145bc2a
Cr-Commit-Position: refs/heads/master@{#392315}

Powered by Google App Engine
This is Rietveld 408576698