Revert of binding: Makes Window/Location's attributes accessor-type properties. (patchset #27 id:520001 of https://codereview.chromium.org/1380503002/ )
Reason for revert:
We hit a (huge) performance regression. See http://crbug.com/608475 .
Original issue's description:
> binding: Makes Window/Location's attributes accessor-type properties.
>
> Makes almost all the attributes (except for cross-origin accessible
> attributes) accessor-type properties. The target attributes in this
> CL are DOM attributes of Window, Location and workers not annotated
> as [DoNotCheckSecurity], which are cross-origin accessible.
>
> BUG=43394, 516274
>
> Committed: https://crrev.com/9ac1750adf85027985c7af3468e0b972c2086235
> Cr-Commit-Position: refs/heads/master@{#390893}
TBR=tkent@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=43394, 516274
Committed: https://crrev.com/0e0d4e2542246e3a53e070aaf82e7570a145bc2a
Cr-Commit-Position: refs/heads/master@{#392315}
Created Revert of binding: Makes Window/Location's attributes accessor-type properties.
4 years, 7 months ago
(2016-05-09 06:43:22 UTC)
#1
Created Revert of binding: Makes Window/Location's attributes accessor-type
properties.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958883003/1
4 years, 7 months ago
(2016-05-09 06:43:35 UTC)
#2
Try jobs failed on following builders: ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/2274)
4 years, 7 months ago
(2016-05-09 06:45:46 UTC)
#4
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958883003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958883003/300001
4 years, 7 months ago
(2016-05-09 13:28:09 UTC)
#9
4 years, 7 months ago
(2016-05-09 14:54:06 UTC)
#10
Message was sent while issue was closed.
Committed patchset #2 (id:300001)
commit-bot: I haz the power
Description was changed from ========== Revert of binding: Makes Window/Location's attributes accessor-type properties. (patchset #27 ...
4 years, 7 months ago
(2016-05-09 14:55:18 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Revert of binding: Makes Window/Location's attributes accessor-type properties.
(patchset #27 id:520001 of https://codereview.chromium.org/1380503002/ )
Reason for revert:
We hit a (huge) performance regression. See http://crbug.com/608475 .
Original issue's description:
> binding: Makes Window/Location's attributes accessor-type properties.
>
> Makes almost all the attributes (except for cross-origin accessible
> attributes) accessor-type properties. The target attributes in this
> CL are DOM attributes of Window, Location and workers not annotated
> as [DoNotCheckSecurity], which are cross-origin accessible.
>
> BUG=43394, 516274
>
> Committed: https://crrev.com/9ac1750adf85027985c7af3468e0b972c2086235
> Cr-Commit-Position: refs/heads/master@{#390893}
TBR=tkent@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=43394, 516274
==========
to
==========
Revert of binding: Makes Window/Location's attributes accessor-type properties.
(patchset #27 id:520001 of https://codereview.chromium.org/1380503002/ )
Reason for revert:
We hit a (huge) performance regression. See http://crbug.com/608475 .
Original issue's description:
> binding: Makes Window/Location's attributes accessor-type properties.
>
> Makes almost all the attributes (except for cross-origin accessible
> attributes) accessor-type properties. The target attributes in this
> CL are DOM attributes of Window, Location and workers not annotated
> as [DoNotCheckSecurity], which are cross-origin accessible.
>
> BUG=43394, 516274
>
> Committed: https://crrev.com/9ac1750adf85027985c7af3468e0b972c2086235
> Cr-Commit-Position: refs/heads/master@{#390893}
TBR=tkent@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=43394, 516274
Committed: https://crrev.com/0e0d4e2542246e3a53e070aaf82e7570a145bc2a
Cr-Commit-Position: refs/heads/master@{#392315}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0e0d4e2542246e3a53e070aaf82e7570a145bc2a Cr-Commit-Position: refs/heads/master@{#392315}
4 years, 7 months ago
(2016-05-09 14:55:19 UTC)
#12
Issue 1958883003: Revert of binding: Makes Window/Location's attributes accessor-type properties.
(Closed)
Created 4 years, 7 months ago by Yuki
Modified 4 years, 7 months ago
Reviewers: tkent, haraken
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0