third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 1958883003: Revert of binding: Makes Window/Location's attributes accessor-type properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1958883003: Revert of binding: Makes Window/Location's attributes accessor-type properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp ('k') | third_party/WebKit/Source/bindings/scripts/idl_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 7af861c21e587c3cbb666b5bdb9f4a70facdfb43..1c427411cb77514abc50541c3ab1579893482af2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -67,7 +67,7 @@

namespace blink {

-void V8Window::eventAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

+void V8Window::eventAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)

{

LocalDOMWindow* impl = toLocalDOMWindow(V8Window::toImpl(info.Holder()));

ExceptionState exceptionState(ExceptionState::GetterContext, "event", "Window", info.Holder(), info.GetIsolate());

@@ -89,7 +89,7 @@ void V8Window::eventAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Val

v8SetReturnValue(info, jsEvent);

}

-void V8Window::eventAttributeSetterCustom(v8::Local<v8::Value> value, const v8::FunctionCallbackInfo<v8::Value>& info)

+void V8Window::eventAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)

{

LocalDOMWindow* impl = toLocalDOMWindow(V8Window::toImpl(info.Holder()));

ExceptionState exceptionState(ExceptionState::SetterContext, "event", "Window", info.Holder(), info.GetIsolate());

@@ -108,7 +108,7 @@ void V8Window::eventAttributeSetterCustom(v8::Local<v8::Value> value, const v8::

V8HiddenValue::setHiddenValue(ScriptState::current(info.GetIsolate()), context->Global(), V8HiddenValue::event(info.GetIsolate()), value);

}

-void V8Window::frameElementAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

+void V8Window::frameElementAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)

{

LocalDOMWindow* impl = toLocalDOMWindow(V8Window::toImpl(info.Holder()));