Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: components/tracing/child_memory_dump_manager_delegate_impl.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/child_memory_dump_manager_delegate_impl.cc
diff --git a/components/tracing/child_memory_dump_manager_delegate_impl.cc b/components/tracing/child_memory_dump_manager_delegate_impl.cc
index ced940b2295c506bc1ffe376e96d343627d3e647..a41b27d324eaed3b9fc7c376240b842dbcfdbef7 100644
--- a/components/tracing/child_memory_dump_manager_delegate_impl.cc
+++ b/components/tracing/child_memory_dump_manager_delegate_impl.cc
@@ -40,7 +40,7 @@ void ChildMemoryDumpManagerDelegateImpl::SetChildTraceMessageFilter(
const auto& task_runner = ctmf ? (ctmf->ipc_task_runner()) : nullptr;
// Check that we are either registering the CTMF or tearing it down, but not
// replacing a valid instance with another one (should never happen).
- DCHECK(ctmf_ == nullptr || (ctmf == nullptr && ctmf_task_runner_ != nullptr));
+ DCHECK(ctmf_ == nullptr || (ctmf == nullptr && ctmf_task_runner_));
danakj 2016/05/10 21:37:02 you could write this DCHECK(!ctmf_ || (!ctmf && c
scheib 2016/05/10 22:25:00 Done.
ctmf_ = ctmf;
{

Powered by Google App Engine
This is Rietveld 408576698