chrome/browser/ui/views/certificate_selector_browsertest.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/certificate_selector_browsertest.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/themes/theme_service.cc ('K') | « chrome/browser/themes/theme_service.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.cc » ('j') | components/tracing/child_memory_dump_manager_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/certificate_selector_browsertest.cc

diff --git a/chrome/browser/ui/views/certificate_selector_browsertest.cc b/chrome/browser/ui/views/certificate_selector_browsertest.cc

index 5824ccce718b371b1a61f234918242debabed39e..5e963ad62355be0842ecec09043768d78d313b55 100644

--- a/chrome/browser/ui/views/certificate_selector_browsertest.cc

+++ b/chrome/browser/ui/views/certificate_selector_browsertest.cc

@@ -74,11 +74,11 @@ class CertificateSelectorTest : public InProcessBrowserTest {

void SetUpInProcessBrowserTestFixture() override {

client_1_ =

net::ImportCertFromFile(net::GetTestCertsDirectory(), "client_1.pem");

- ASSERT_NE(nullptr, client_1_);

+ ASSERT_FALSE(client_1_);

danakj 2016/05/10 21:37:02 TRUE

scheib 2016/05/10 22:25:00 Done.

client_2_ =

net::ImportCertFromFile(net::GetTestCertsDirectory(), "client_2.pem");

- ASSERT_NE(nullptr, client_2_);

+ ASSERT_FALSE(client_2_);

danakj 2016/05/10 21:37:02 TRUE

scheib 2016/05/10 22:25:00 Done.

}

void SetUpOnMainThread() override {