ui/gfx/win/direct_write.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/win/direct_write.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/win/direct_write.cc

diff --git a/ui/gfx/win/direct_write.cc b/ui/gfx/win/direct_write.cc

index 91ab99b942d9989281bbb1db4cc36df53a74a755..90fd728d6beef8ef885b4472a5b0268aecb8e06b 100644

--- a/ui/gfx/win/direct_write.cc

+++ b/ui/gfx/win/direct_write.cc

@@ -54,7 +54,7 @@ void MaybeInitializeDirectWrite() {

base::win::ScopedComPtr<IDWriteFactory> factory;

CreateDWriteFactory(factory.Receive());

- if (factory == nullptr)

+ if (!factory)

return;

// The skia call to create a new DirectWrite font manager instance can fail

« no previous file with comments | « net/quic/crypto/quic_crypto_server_config.cc ('k') | ui/gl/gl_image_ozone_native_pixmap_unittest.cc » ('j') | no next file with comments »