net/quic/crypto/quic_crypto_server_config.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/quic_crypto_server_config.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/quic_crypto_server_config.cc

diff --git a/net/quic/crypto/quic_crypto_server_config.cc b/net/quic/crypto/quic_crypto_server_config.cc

index a5419db1e41440e97ce1760b589f59f0bfef8e83..571bb1cb950dd97ecea46dbcdb00b170d3202276 100644

--- a/net/quic/crypto/quic_crypto_server_config.cc

+++ b/net/quic/crypto/quic_crypto_server_config.cc

@@ -1013,8 +1013,7 @@ void QuicCryptoServerConfig::EvaluateClientHello(

HandshakeFailureReason source_address_token_error = MAX_FAILURE_REASON;

StringPiece srct;

if (client_hello.GetStringPiece(kSourceAddressTokenTag, &srct)) {

- Config& config =

- requested_config != nullptr ? *requested_config : *primary_config;

+ Config& config = requested_config ? *requested_config : *primary_config;

source_address_token_error =

ParseSourceAddressToken(config, srct, &info->source_address_tokens);

« no previous file with comments | « net/proxy/proxy_script_decider_unittest.cc ('k') | ui/gfx/win/direct_write.cc » ('j') | no next file with comments »