Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3157)

Unified Diff: cc/trees/layer_tree_host_unittest_serialization.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_video_frame_provider.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_serialization.cc
diff --git a/cc/trees/layer_tree_host_unittest_serialization.cc b/cc/trees/layer_tree_host_unittest_serialization.cc
index 00852bc1d0f436edec325d3ccce7bb33fb12f591..7d989d66fa269242819fa4c3679840db58d2d799 100644
--- a/cc/trees/layer_tree_host_unittest_serialization.cc
+++ b/cc/trees/layer_tree_host_unittest_serialization.cc
@@ -131,31 +131,31 @@ class LayerTreeHostSerializationTest : public testing::Test {
}
EXPECT_TRUE(found_hud_layer_type);
} else {
- EXPECT_EQ(nullptr, layer_tree_host_dst_->hud_layer_);
+ EXPECT_FALSE(layer_tree_host_dst_->hud_layer_);
}
if (layer_tree_host_src_->overscroll_elasticity_layer_) {
EXPECT_EQ(layer_tree_host_src_->overscroll_elasticity_layer_->id(),
layer_tree_host_dst_->overscroll_elasticity_layer_->id());
} else {
- EXPECT_EQ(nullptr, layer_tree_host_dst_->overscroll_elasticity_layer_);
+ EXPECT_FALSE(layer_tree_host_dst_->overscroll_elasticity_layer_);
}
if (layer_tree_host_src_->page_scale_layer_) {
EXPECT_EQ(layer_tree_host_src_->page_scale_layer_->id(),
layer_tree_host_dst_->page_scale_layer_->id());
} else {
- EXPECT_EQ(nullptr, layer_tree_host_dst_->page_scale_layer_);
+ EXPECT_FALSE(layer_tree_host_dst_->page_scale_layer_);
}
if (layer_tree_host_src_->inner_viewport_scroll_layer_) {
EXPECT_EQ(layer_tree_host_src_->inner_viewport_scroll_layer_->id(),
layer_tree_host_dst_->inner_viewport_scroll_layer_->id());
} else {
- EXPECT_EQ(nullptr, layer_tree_host_dst_->inner_viewport_scroll_layer_);
+ EXPECT_FALSE(layer_tree_host_dst_->inner_viewport_scroll_layer_);
}
if (layer_tree_host_src_->outer_viewport_scroll_layer_) {
EXPECT_EQ(layer_tree_host_src_->outer_viewport_scroll_layer_->id(),
layer_tree_host_dst_->outer_viewport_scroll_layer_->id());
} else {
- EXPECT_EQ(nullptr, layer_tree_host_dst_->outer_viewport_scroll_layer_);
+ EXPECT_FALSE(layer_tree_host_dst_->outer_viewport_scroll_layer_);
}
EXPECT_EQ(layer_tree_host_src_->selection_,
layer_tree_host_dst_->selection_);
« no previous file with comments | « cc/test/fake_video_frame_provider.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698