mus: Use BufferQueue and GLHelper from display_compositor.

mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

Also, remove the unused mus version of GLHelper.

BUG=none

Committed: https://crrev.com/58cf30b907708332c5e4d8788f464abff853c0cf
Cr-Commit-Position: refs/heads/master@{#392433}

[sadrul, 2016-05-07 02:13:47]

sadrul@chromium.org changed reviewers:
+ fsamuel@chromium.org, rjkroege@chromium.org

[sadrul, 2016-05-07 02:13:48]

https://codereview.chromium.org/1958813002/diff/1/components/mus/surfaces/dir...
File components/mus/surfaces/direct_output_surface_ozone.h (right):

https://codereview.chromium.org/1958813002/diff/1/components/mus/surfaces/dir...
components/mus/surfaces/direct_output_surface_ozone.h:72:
std::unique_ptr<display_compositor::BufferQueue> output_surface_;
While I am here, should I rename this to buffer_queue_?

[Fady Samuel, 2016-05-07 04:12:27]

Could we also get rid of mus' GLHelper?

[sadrul, 2016-05-07 04:39:34]

Description was changed from

==========
mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

BUG=none
==========

to

==========
mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

Also, remove the unused mus version of GLHelper.

BUG=none
==========

[sadrul, 2016-05-07 04:42:22]

On 2016/05/07 04:12:27, Fady Samuel wrote:
> Could we also get rid of mus' GLHelper?

Oh yeah, good catch. Thanks. Done.

[Fady Samuel, 2016-05-07 05:16:38]

lgtm if Rob is happy with it.

[sadrul, 2016-05-07 17:02:07]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2016-05-07 17:02:08]

+piman@ as display_compositor owner for added DEPS on it from mus/surfaces/

[piman, 2016-05-09 15:22:19]

lgtm

[rjkroege, 2016-05-09 17:56:30]

lgtm

[sadrul, 2016-05-09 20:03:29]

Tested on a device. Seems to be working fine. Putting this in the CQ. Thanks for
the quick reviews!

[sadrul, 2016-05-09 20:11:19]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:11:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958813002/20001

[commit-bot: I haz the power, 2016-05-09 22:04:43]

Description was changed from

==========
mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

Also, remove the unused mus version of GLHelper.

BUG=none
==========

to

==========
mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

Also, remove the unused mus version of GLHelper.

BUG=none
==========

[commit-bot: I haz the power, 2016-05-09 22:04:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 22:06:52]

Description was changed from

==========
mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

Also, remove the unused mus version of GLHelper.

BUG=none
==========

to

==========
mus: Use BufferQueue and GLHelper from display_compositor.

Remove the mus-version of BufferQueue, and use the display_compositor version
instead. To allow for this, also use a GLHelper instance, and an ozone impl of
gpu::GpuMemoryBufferManager (called mus::OzoneGpuMemoryBufferManager).

Also, remove the unused mus version of GLHelper.

BUG=none

Committed: https://crrev.com/58cf30b907708332c5e4d8788f464abff853c0cf
Cr-Commit-Position: refs/heads/master@{#392433}
==========

[commit-bot: I haz the power, 2016-05-09 22:06:53]

Patchset 2 (id:??) landed as
https://crrev.com/58cf30b907708332c5e4d8788f464abff853c0cf
Cr-Commit-Position: refs/heads/master@{#392433}