Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tools/gn/ninja_build_writer_unittest.cc

Issue 1958783003: GN: Prefer toplevel targets for phony names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer_unittest.cc
diff --git a/tools/gn/ninja_build_writer_unittest.cc b/tools/gn/ninja_build_writer_unittest.cc
index f82dc83552178b5a4432d7dfb07ade8b29e3385b..48d73028e177ae4bc7e6f4748428dcc748670024 100644
--- a/tools/gn/ninja_build_writer_unittest.cc
+++ b/tools/gn/ninja_build_writer_unittest.cc
@@ -53,13 +53,15 @@ TEST(NinjaBuildWriter, TwoTargets) {
"subninja toolchain.ninja\n"
"\n";
const char expected_targets[] =
+ "build bar: phony obj/bar/bar.stamp\n"
"build foo$:bar: phony obj/foo/bar.stamp\n"
"build bar$:bar: phony obj/bar/bar.stamp\n"
- "build bar: phony obj/bar/bar.stamp\n"
"\n";
const char expected_root_target[] =
- "build all: phony obj/foo/bar.stamp $\n"
+ "build all: phony $\n"
+ " obj/foo/bar.stamp $\n"
" obj/bar/bar.stamp\n"
+ "\n"
"default all\n";
std::string out_str = ninja_out.str();
#define EXPECT_SNIPPET(expected) \
« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698