GN: Prefer toplevel targets for phony names.

tools/gn/ninja_build_writer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/ninja_build_writer.h"
 #include "tools/gn/scheduler.h"
 #include "tools/gn/target.h"
@@ skipping 35 matching lines @@
       "  depfile = build.ninja.d\n"
       "\n";
   const char expected_link_pool[] =
       "pool link_pool\n"
       "  depth = 0\n"
       "\n";
   const char expected_toolchain[] =
       "subninja toolchain.ninja\n"
       "\n";
   const char expected_targets[] =
+      "build bar: phony obj/bar/bar.stamp\n"
       "build foo$:bar: phony obj/foo/bar.stamp\n"
       "build bar$:bar: phony obj/bar/bar.stamp\n"
-      "build bar: phony obj/bar/bar.stamp\n"
       "\n";
   const char expected_root_target[] =
-      "build all: phony obj/foo/bar.stamp $\n"
+      "build all: phony $\n"
+      "    obj/foo/bar.stamp $\n"
       "    obj/bar/bar.stamp\n"
+      "\n"
       "default all\n";
   std::string out_str = ninja_out.str();
 #define EXPECT_SNIPPET(expected) \
     EXPECT_NE(std::string::npos, out_str.find(expected)) << \
         "Expected to find: " << expected << std::endl << \
         "Within: " << out_str
   EXPECT_SNIPPET(expected_rule_gn);
   EXPECT_SNIPPET(expected_build_ninja);
   EXPECT_SNIPPET(expected_link_pool);
   EXPECT_SNIPPET(expected_toolchain);
@@ skipping 37 matching lines @@
       "\n"
       "This is can often be fixed by changing one of the target names, or by \n"
       "setting an output_name on one of them.\n"
       "\n"
       "Collisions:\n"
       "  //foo:bar\n"
       "  //bar:bar\n";
 
   EXPECT_EQ(expected_help_test, err.help_text());
 }