Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1958523002: Make WebAPK naming consistent 1/2 (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Xi Han
CC:
Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebAPK naming consistent 1/2 This CL makes the naming more consistent. - Comments use WebAPK (not WebAPK, WebApk etc) - Function names use WebApk e.g void makeWebApk() {} - C++ variable names use webapk e.g. std::string webapk_package_name = ""; BUG=609488

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkSwitches.java View 1 chunk +1 line, -1 line 0 comments Download
M webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 4 chunks +10 lines, -10 lines 0 comments Download
M webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersionManager.java View 3 chunks +4 lines, -4 lines 0 comments Download
M webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (6 generated)
pkotwicz
Xi can you please take a look? I used the following script the fix up ...
4 years, 7 months ago (2016-05-06 01:23:20 UTC) #4
Xi Han
4 years, 7 months ago (2016-05-06 13:41:49 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698