chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java - Issue 1958523002: Make WebAPK naming consistent 1/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 1958523002: Make WebAPK naming consistent 1/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

index 878115557bf93587f4e95e96af82ac8504cfb0b1..b53bea3b5b557923e2a08cd050c7ee8915b30723 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

@@ -200,10 +200,10 @@ public class ExternalNavigationHandler {

// http://crbug/331571 : Do not override a navigation started from user typing.

// http://crbug/424029 : Need to stay in Chrome for an intent heading explicitly to Chrome.

// BookmarkUrl#openUrl() sends an intent to Chrome to open a bookmark. When the url is

- // within the scope of a web APK, the web APK should handle the navigation when the

+ // within the scope of a WebAPK, the WebAPK should handle the navigation when the

// bookmark is tapped.

// When the user selects "Chrome" from the intent picker for a URL which falls within the

- // scope of a web APK, Chrome should handle the navigation to the URL.

+ // scope of a WebAPK, Chrome should handle the navigation to the URL.

// TODO(pkotwicz|hanxi): http://crbug/ 604372. Devise a way of differentiating the two

// cases.

if (params.getRedirectHandler() != null) {