Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: mojo/public/interfaces/bindings/mojom_files.mojom

Issue 1958463003: Mojom compiler: Eliminate duplicate representation of enum values in mojom_files.mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Responded to code reveiw comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/go/tests/validation_type_test.go ('k') | mojo/public/interfaces/bindings/mojom_types.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/interfaces/bindings/mojom_files.mojom
diff --git a/mojo/public/interfaces/bindings/mojom_files.mojom b/mojo/public/interfaces/bindings/mojom_files.mojom
index 69144345e1531c99ea6f7f39663bc2c9845faba0..823f4e318ecc9f6b7c596e3ae41ae327a7b4822d 100644
--- a/mojo/public/interfaces/bindings/mojom_files.mojom
+++ b/mojo/public/interfaces/bindings/mojom_files.mojom
@@ -17,8 +17,8 @@ import "mojom_types.mojom";
* code generators passing them data derived from the MojomFileGraph.
*
* A MojomFile represents the data parsed from a single .mojom file. Mojom
- * modules form a directed acyclic graph via the "imports" relation.
- * That is, if Module A imports Module B then there is a directed edge in the
+ * files form a directed acyclic graph via the "imports" relation.
+ * That is, if file A imports file B then there is a directed edge in the
* graph from A to B. A MojomFileGraph represents the whole Graph.
* The Mojom structures represented here have been fully resolved, meaning that
@@ -81,27 +81,26 @@ struct MojomFileGraph {
// All the files in this graph. The keys are |file_name|s.
map<string, MojomFile> files;
- // All the resolved user-defined types known to this structure. The keys are
+ // All the resolved user-defined types in all the files in the graph. The keys are
// the |type_key|s.
map<string, UserDefinedType> resolved_types;
- // All the resolved user-defined values known to this structure. The keys are
- // the |value_key|s.
- map<string, UserDefinedValue> resolved_values;
+ // All the resolved DeclaredConstants in all the files in the graph. The keys are
+ // the |constant_key|s.
+ map<string, DeclaredConstant> resolved_constants;
};
-// A KeysByType struct organizes by type all of the type and constant keys known
-// to an associated MojomFileGraph.
+// A KeysByType struct organizes by type the keys of all types and consants in
+// a MojomFile
struct KeysByType {
- // All the type_keys known to the owning MojomFileGraph, organized by
- // type;
+ // The type keys of the types in the MojomFile.
array<string>? interfaces;
array<string>? structs;
array<string>? unions;
array<string>? top_level_enums;
array<string>? embedded_enums;
- // All the constant_keys known to the owning MojomFileGraph.
+ // The constant keys of the constants in the MojomFile.
array<string>? top_level_constants;
array<string>? embedded_constants;
};
« no previous file with comments | « mojo/go/tests/validation_type_test.go ('k') | mojo/public/interfaces/bindings/mojom_types.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698