Mojom compiler: Eliminate duplicate representation of enum values in mojom_files.mojom.

mojo/public/interfaces/bindings/mojom_files.mojom

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 [DartPackage="mojo",
  JavaPackage="org.chromium.mojo.bindings.types"]
 module mojo.bindings.types;
 
 import "mojom_types.mojom";
 
 /*
  * The structures in this file are intended to be used by the Mojom compiler
  * and code generators. The front end of the compiler takes as input a
  * .mojom file (or a list of .mojom files) and produces a MojomFileGraph struct.
  *
  * The backend of the compiler consumes a MojomFileGraph and invokes each of the
  * code generators passing them data derived from the MojomFileGraph.
  *
  * A MojomFile represents the data parsed from a single .mojom file. Mojom
- * modules form a directed acyclic graph via the "imports" relation.
- * That is, if Module A imports Module B then there is a directed edge in the
+ * files form a directed acyclic graph via the "imports" relation.
+ * That is, if file A imports file B then there is a directed edge in the
  * graph from A to B. A MojomFileGraph represents the whole Graph.
 
  * The Mojom structures represented here have been fully resolved, meaning that
  * the type references have been associated with their corresponding type
  * definitions. This resolved type data is contained in the resolved_types data
  * in MojomFileGraph.
  */
 
 // A MojomFile represents the data defined by a single .mojom file, when
 // all of the type references to types declared in imported .mojom files
@@ skipping 42 matching lines @@
   // this. This string contains the base64 encoding of the gzip-compressed
   // bytes.
   string? serialized_runtime_type_info;
 };
 
 // Represents a directed acyclic graph of MojomFiles.
 struct MojomFileGraph {
   // All the files in this graph. The keys are |file_name|s.
   map<string, MojomFile> files;
 
-  // All the resolved user-defined types known to this structure. The keys are
+  // All the resolved user-defined types in all the files in the graph. The keys are
   // the |type_key|s.
   map<string, UserDefinedType> resolved_types;
 
-  // All the resolved user-defined values known to this structure. The keys are
-  // the |value_key|s.
-  map<string, UserDefinedValue> resolved_values;
+  // All the resolved DeclaredConstants in all the files in the graph. The keys are
+  // the |constant_key|s.
+  map<string, DeclaredConstant> resolved_constants;
 };
 
-// A KeysByType struct organizes by type all of the type and constant keys known
-// to an associated MojomFileGraph.
+// A KeysByType struct organizes by type the keys of all types and consants in
+// a MojomFile
 struct KeysByType {
-  // All the type_keys known to the owning MojomFileGraph, organized by
-  // type;
+  // The type keys of the types in the MojomFile.
   array<string>? interfaces;
   array<string>? structs;
   array<string>? unions;
   array<string>? top_level_enums;
   array<string>? embedded_enums;
 
-  // All the constant_keys known to the owning MojomFileGraph.
+  // The constant keys of the constants in the MojomFile.
   array<string>? top_level_constants;
   array<string>? embedded_constants;
 };