Prevent audio thread access to finished, non-active AudioNodes.

Prevent audio thread access to finished, non-active AudioNodes.

Follow up r392110 and have the audio thread skip over m_activeSourceNodes
nodes it has already deemed to be finished & removable by the main thread.
Accessing these cannot be safely done.

R=
BUG=610643
Committed: https://crrev.com/ac763683bafd8fe61ef1fe3285152b37d2bdab24
Cr-Commit-Position: refs/heads/master@{#392720}

[sof, 2016-05-10 15:20:14]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, hongchan@chromium.org, rtoy@chromium.org

[sof, 2016-05-10 15:20:14]

please take a look.

[haraken, 2016-05-10 15:22:30]

LGTM on my side.

[Raymond Toy, 2016-05-10 16:04:20]

lgtm with nit

https://codereview.chromium.org/1958333006/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1958333006/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:831: if
(m_finishedSourceNodes.contains(node))
Can you add a comment here why you're skipping active nodes that are deemed
finished?

In 6 mo, I will forget why this is here. :-(

[hongchan, 2016-05-10 16:54:55]

lgtm

[sof, 2016-05-10 19:09:09]

https://codereview.chromium.org/1958333006/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1958333006/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:831: if
(m_finishedSourceNodes.contains(node))
On 2016/05/10 16:04:20, Raymond Toy wrote:
> Can you add a comment here why you're skipping active nodes that are deemed
> finished?
> 
> In 6 mo, I will forget why this is here. :-(

Added comment, let's see if it makes sense in 6 months time :)

[sof, 2016-05-10 19:15:54]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-05-10 19:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rtoy@chromium.org, hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1958333006/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2016-05-10 19:16:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958333006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958333006/20001

[Raymond Toy, 2016-05-10 19:54:57]

https://codereview.chromium.org/1958333006/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1958333006/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:831: if
(m_finishedSourceNodes.contains(node))
On 2016/05/10 19:09:09, sof wrote:
> On 2016/05/10 16:04:20, Raymond Toy wrote:
> > Can you add a comment here why you're skipping active nodes that are deemed
> > finished?
> > 
> > In 6 mo, I will forget why this is here. :-(
> 
> Added comment, let's see if it makes sense in 6 months time :)

Excellent!  At least I'll have some understanding of why, even if I don't fully
remember. :-)

[commit-bot: I haz the power, 2016-05-10 21:14:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 21:15:46]

Description was changed from

==========
Prevent audio thread access to finished, non-active AudioNodes.

Follow up r392110 and have the audio thread skip over m_activeSourceNodes
nodes it has already deemed to be finished & removable by the main thread.
Accessing these cannot be safely done.

R=
BUG=610643
==========

to

==========
Prevent audio thread access to finished, non-active AudioNodes.

Follow up r392110 and have the audio thread skip over m_activeSourceNodes
nodes it has already deemed to be finished & removable by the main thread.
Accessing these cannot be safely done.

R=
BUG=610643

Committed: https://crrev.com/ac763683bafd8fe61ef1fe3285152b37d2bdab24
Cr-Commit-Position: refs/heads/master@{#392720}
==========

[commit-bot: I haz the power, 2016-05-10 21:15:47]

Patchset 2 (id:??) landed as
https://crrev.com/ac763683bafd8fe61ef1fe3285152b37d2bdab24
Cr-Commit-Position: refs/heads/master@{#392720}