third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h - Issue 1958333006: Prevent audio thread access to finished, non-active AudioNodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

Issue 1958333006: Prevent audio thread access to finished, non-active AudioNodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

index a0c44233399c801f7aca3c235faedc4a1f77c1a6..c20bc028f496cc6d47ab09d41cee1704eee4f42b 100644

--- a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

+++ b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

@@ -320,7 +320,7 @@ private:

// are performed by it. When the audio thread marks a source node as finished,

// the nodes are added to |m_finishedSourceNodes| and scheduled for removal

// from |m_activeSourceNodes| by the main thread.

- Vector<UntracedMember<AudioNode>> m_finishedSourceNodes;

+ HashSet<UntracedMember<AudioNode>> m_finishedSourceNodes;

// FIXME(dominicc): Move these to AudioContext because only

// it creates these Promises.

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp » ('j') | no next file with comments »