Throttling Helper to disable task queue until PumpThrottledTasks called

Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Unfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptably.  In the context of
task blocking, its totally broken and the queues might as well not have
been throttled at all.

This patch fixes that by initially disabling any queues that are
throttled.  The queues are re-enabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
Committed: https://crrev.com/82a129abeafa1bd8184b5c3e61ab2c7568edd3f8
Cr-Commit-Position: refs/heads/master@{#392614}

[alex clarke (OOO till 29th), 2016-05-10 13:42:18]

Description was changed from

==========
Throttling Helper to diable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Uunfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptiably.  In the context of
task blocking, its totally broken and the queus might as well not have
been throttled at all.

This patch fixes that by initally disabling any queues that are
throttled.  The queues are reenabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

to

==========
Throttling Helper to diable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Uunfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptiably.  In the context of
task blocking, its totally broken and the queus might as well not have
been throttled at all.

This patch fixes that by initally disabling any queues that are
throttled.  The queues are reenabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

[alex clarke (OOO till 29th), 2016-05-10 13:42:18]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2016-05-10 13:42:25]

PTAL

[alex clarke (OOO till 29th), 2016-05-10 13:42:42]

Description was changed from

==========
Throttling Helper to diable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Uunfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptiably.  In the context of
task blocking, its totally broken and the queus might as well not have
been throttled at all.

This patch fixes that by initally disabling any queues that are
throttled.  The queues are reenabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

to

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Uunfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptiably.  In the context of
task blocking, its totally broken and the queus might as well not have
been throttled at all.

This patch fixes that by initally disabling any queues that are
throttled.  The queues are reenabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

[alex clarke (OOO till 29th), 2016-05-10 13:43:06]

Description was changed from

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Uunfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptiably.  In the context of
task blocking, its totally broken and the queus might as well not have
been throttled at all.

This patch fixes that by initally disabling any queues that are
throttled.  The queues are reenabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

to

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Unfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptably.  In the context of
task blocking, its totally broken and the queues might as well not have
been throttled at all.

This patch fixes that by initially disabling any queues that are
throttled.  The queues are re-enabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

[Sami, 2016-05-10 14:28:56]

lgtm, thanks for the fix.

https://codereview.chromium.org/1958283005/diff/20001/components/scheduler/re...
File components/scheduler/renderer/renderer_scheduler_impl_unittest.cc (right):

https://codereview.chromium.org/1958283005/diff/20001/components/scheduler/re...
components/scheduler/renderer/renderer_scheduler_impl_unittest.cc:2708: // will
be disabled until the thottled queue is pumped.
typo: throttled

[alex clarke (OOO till 29th), 2016-05-10 14:35:33]

https://codereview.chromium.org/1958283005/diff/20001/components/scheduler/re...
File components/scheduler/renderer/renderer_scheduler_impl_unittest.cc (right):

https://codereview.chromium.org/1958283005/diff/20001/components/scheduler/re...
components/scheduler/renderer/renderer_scheduler_impl_unittest.cc:2708: // will
be disabled until the thottled queue is pumped.
On 2016/05/10 14:28:56, Sami wrote:
> typo: throttled

Done.

[alex clarke (OOO till 29th), 2016-05-10 14:35:37]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-05-10 14:35:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1958283005/#ps40001
(title: "fix typo")

[commit-bot: I haz the power, 2016-05-10 14:35:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958283005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958283005/40001

[commit-bot: I haz the power, 2016-05-10 15:29:02]

Description was changed from

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Unfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptably.  In the context of
task blocking, its totally broken and the queues might as well not have
been throttled at all.

This patch fixes that by initially disabling any queues that are
throttled.  The queues are re-enabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

to

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Unfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptably.  In the context of
task blocking, its totally broken and the queues might as well not have
been throttled at all.

This patch fixes that by initially disabling any queues that are
throttled.  The queues are re-enabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

[commit-bot: I haz the power, 2016-05-10 15:29:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-10 15:31:27]

Description was changed from

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Unfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptably.  In the context of
task blocking, its totally broken and the queues might as well not have
been throttled at all.

This patch fixes that by initially disabling any queues that are
throttled.  The queues are re-enabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202
==========

to

==========
Throttling Helper to disable task queue until PumpThrottledTasks called

This patch fixes a bug that caused some loading & timer tasks to run
when we expected them to be blocked.  In SYNCHRONIZED_GESTURE use case
we use the ThrottlingHelper to allow these tasks to run once per second.
Unfortunately the design of the ThrottlingHelper did not consider tasks
that where in a TaskQueue's work queues.  It marked the queues as being
manually pumped which prevented reloading of the work queues.

For the case of background tab throttling where the throttle state
changes very infrequently, that works acceptably.  In the context of
task blocking, its totally broken and the queues might as well not have
been throttled at all.

This patch fixes that by initially disabling any queues that are
throttled.  The queues are re-enabled by PumpThrottledTasks() and also
if the queue is unthrottled.

BUG=600202

Committed: https://crrev.com/82a129abeafa1bd8184b5c3e61ab2c7568edd3f8
Cr-Commit-Position: refs/heads/master@{#392614}
==========

[commit-bot: I haz the power, 2016-05-10 15:31:28]

Patchset 3 (id:??) landed as
https://crrev.com/82a129abeafa1bd8184b5c3e61ab2c7568edd3f8
Cr-Commit-Position: refs/heads/master@{#392614}