Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 1958283005: Throttling Helper to disable task queue until PumpThrottledTasks called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index 1a8944443ae6c699d3cef55ec96911ca2136af1f..4cd13511f002d5581dc273035d0d48f108f8e949 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -2672,6 +2672,9 @@ TEST_F(RendererSchedulerImplTest,
SYNCHRONIZED_GESTURE_TimerTaskThrottling_task_expensive) {
SimulateCompositorGestureStart(TouchEventPolicy::SEND_TOUCH_START);
+ base::TimeTicks first_throttled_run_time =
+ ThrottlingHelper::ThrottledRunTime(clock_->NowTicks());
+
size_t count = 0;
// With the compositor task taking 10ms, there is not enough time to run this
// 7ms timer task in the 16ms frame.
@@ -2700,11 +2703,18 @@ TEST_F(RendererSchedulerImplTest,
base::Bind(&RendererSchedulerImplTest::SimulatedCompositorTaskPending,
base::Unretained(this)));
EXPECT_EQ(UseCase::SYNCHRONIZED_GESTURE, CurrentUseCase()) << "i = " << i;
- EXPECT_TRUE(scheduler_->TimerTaskRunner()->IsQueueEnabled()) << "i = " << i;
+
+ // Before the policy is updated the queue will be enabled. Subsequently it
+ // will be disabled until the throttled queue is pumped.
+ bool expect_queue_enabled =
+ (i == 0) || (clock_->NowTicks() > first_throttled_run_time);
+ EXPECT_EQ(expect_queue_enabled,
+ scheduler_->TimerTaskRunner()->IsQueueEnabled())
+ << "i = " << i;
}
// Task is throttled but not completely blocked.
- EXPECT_EQ(13u, count);
+ EXPECT_EQ(12u, count);
}
TEST_F(RendererSchedulerImplTest,
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | components/scheduler/renderer/throttling_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698