Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1958283003: Also call SetAlwaysTranslate when the button id is BUTTON_ID_TRANSLATE in the base view (Closed)

Created:
4 years, 7 months ago by ftang
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also call SetAlwaysTranslate when the button id is BUTTON_ID_TRANSLATE in the base view. BUG=610373 Committed: https://crrev.com/a4fea5c663ae5553743c86f55caafce44294a46b Cr-Commit-Position: refs/heads/master@{#392649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ftang
Please review this fix. I forget the base view use a different button id for ...
4 years, 7 months ago (2016-05-10 01:21:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958283003/1
4 years, 7 months ago (2016-05-10 01:22:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 02:03:10 UTC) #6
msw
lgtm
4 years, 7 months ago (2016-05-10 16:57:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958283003/1
4 years, 7 months ago (2016-05-10 18:11:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 18:17:25 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:19:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4fea5c663ae5553743c86f55caafce44294a46b
Cr-Commit-Position: refs/heads/master@{#392649}

Powered by Google App Engine
This is Rietveld 408576698