Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1958233002: Reland of Update NTP to new material design spec. (Closed)

Created:
4 years, 7 months ago by Bernhard Bauer
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Update NTP to new material design spec. (patchset #1 id:1 of https://codereview.chromium.org/1962063002/ ) Reason for revert: Not considered a Dev blocker; will be fixed in followup CL. Original issue's description: > Revert of Update NTP to new material design spec. (patchset #2 id:20001 of https://codereview.chromium.org/1960553003/ ) > > Reason for revert: > Regression cause in incognito: https://bugs.chromium.org/p/chromium/issues/detail?id=610192 > > Original issue's description: > > Update NTP to new material design spec. > > > > Also add a feature flag so we can disable if necessary. > > > > Screenshots here of NTP with snippets off and snippets on: > > http://imgur.com/a/Wd04S > > > > BUG=609112 > > > > Committed: https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7 > > Cr-Commit-Position: refs/heads/master@{#392250} > > TBR=bauerb@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=609112 > > Committed: https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d > Cr-Commit-Position: refs/heads/master@{#392382} TBR=maybelle@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609112 Committed: https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61 Cr-Commit-Position: refs/heads/master@{#392387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M chrome/android/java/res/layout/new_tab_page_recycler_view.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_view.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bernhard Bauer
Created Reland of Update NTP to new material design spec.
4 years, 7 months ago (2016-05-09 19:04:43 UTC) #1
Pam (message me for reviews)
On 2016/05/09 19:04:43, Bernhard Bauer wrote: > Created Reland of Update NTP to new material ...
4 years, 7 months ago (2016-05-09 19:06:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958233002/1
4 years, 7 months ago (2016-05-09 19:07:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 19:08:39 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 19:10:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61
Cr-Commit-Position: refs/heads/master@{#392387}

Powered by Google App Engine
This is Rietveld 408576698