Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_view.xml

Issue 1958233002: Reland of Update NTP to new material design spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <org.chromium.chrome.browser.ntp.NewTabPageView 6 <org.chromium.chrome.browser.ntp.NewTabPageView
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 android:layout_width="match_parent" 8 android:layout_width="match_parent"
9 android:layout_height="match_parent" 9 android:layout_height="match_parent"
10 android:paddingTop="@dimen/tab_strip_height" > 10 android:paddingTop="@dimen/tab_strip_height" >
11 11
12 <ViewStub 12 <ViewStub
13 android:id="@+id/new_tab_page_layout_stub" 13 android:id="@+id/new_tab_page_layout_stub"
14 android:inflatedId="@+id/ntp_scrollview" 14 android:inflatedId="@+id/ntp_scrollview"
15 android:layout_width="match_parent" 15 android:layout_width="match_parent"
16 android:layout_height="match_parent" 16 android:layout_height="match_parent"
17 android:layout_marginBottom="48dp" /> 17 android:layout_marginBottom="48dp" />
18 18
19 <!-- Bookmarks and Recent tabs buttons --> 19 <!-- Bookmarks and Recent tabs buttons -->
20 <org.chromium.chrome.browser.ntp.NewTabPageToolbar 20 <org.chromium.chrome.browser.ntp.NewTabPageToolbar
21 android:id="@+id/ntp_toolbar" 21 android:id="@+id/ntp_toolbar"
22 android:background="@color/ntp_bg"
23 android:layout_width="match_parent" 22 android:layout_width="match_parent"
24 android:layout_height="48dp" 23 android:layout_height="48dp"
25 android:layout_gravity="bottom" 24 android:layout_gravity="bottom"
26 android:orientation="horizontal" > 25 android:orientation="horizontal" >
27 <!-- Each button is a FrameLayout. Why? The TextView contains both text and a compound 26 <!-- Each button is a FrameLayout. Why? The TextView contains both text and a compound
28 drawable icon. If the TextView is half the screen width, the icon w ill be at the left 27 drawable icon. If the TextView is half the screen width, the icon w ill be at the left
29 edge of the TextView even while the text is centered. To center the icon along with the 28 edge of the TextView even while the text is centered. To center the icon along with the
30 text, we need to set the TextView's width to wrap_content; but sinc e the button needs 29 text, we need to set the TextView's width to wrap_content; but sinc e the button needs
31 to be half the screen width, we wrap the TextView in a FrameLayout, whose width can 30 to be half the screen width, we wrap the TextView in a FrameLayout, whose width can
32 expand as needed. --> 31 expand as needed. -->
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 android:layout_height="match_parent" 82 android:layout_height="match_parent"
84 android:layout_gravity="center_horizontal" 83 android:layout_gravity="center_horizontal"
85 android:drawablePadding="8dp" 84 android:drawablePadding="8dp"
86 android:gravity="center_vertical" 85 android:gravity="center_vertical"
87 android:text="@string/recent_tabs" 86 android:text="@string/recent_tabs"
88 android:textSize="12sp" 87 android:textSize="12sp"
89 android:textColor="#5a5a5a" /> 88 android:textColor="#5a5a5a" />
90 </FrameLayout> 89 </FrameLayout>
91 </org.chromium.chrome.browser.ntp.NewTabPageToolbar> 90 </org.chromium.chrome.browser.ntp.NewTabPageToolbar>
92 </org.chromium.chrome.browser.ntp.NewTabPageView> 91 </org.chromium.chrome.browser.ntp.NewTabPageView>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_recycler_view.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698