Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1958183002: Revert of Work around a clang-cl devirtualization bug. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, haraken, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Work around a clang-cl devirtualization bug. (patchset #2 id:20001 of https://codereview.chromium.org/1949653002/ ) Reason for revert: We fixed the compiler bug, this should no longer be needed. Original issue's description: > Work around a clang-cl devirtualization bug. > > clang-cl currently miscompiles calls to virtual methods of base classes > of a final class. Since the type is final, it tries to devirtualize the call, > but then it forgets to apply the right this adjustment. > > https://codereview.chromium.org/1938853002 added static_casts to a super class > for visibility reasons, exposing this bug. > > BUG=608705 > R=rouslan@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/9306e66e5e680801132688b987fe850f1bb43b7a TBR=rouslan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608705 Committed: https://crrev.com/c19da3c46af754416c299b6dacf2223f402b1b34 Cr-Commit-Position: refs/heads/master@{#392371}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
Created Revert of Work around a clang-cl devirtualization bug.
4 years, 7 months ago (2016-05-09 16:51:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958183002/1
4 years, 7 months ago (2016-05-09 16:52:04 UTC) #2
please use gerrit instead
lgtm
4 years, 7 months ago (2016-05-09 16:53:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/2450) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-09 16:54:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958183002/40001
4 years, 7 months ago (2016-05-09 16:58:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-09 18:25:52 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:28:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c19da3c46af754416c299b6dacf2223f402b1b34
Cr-Commit-Position: refs/heads/master@{#392371}

Powered by Google App Engine
This is Rietveld 408576698