Chromium Code Reviews
DescriptionRevert of Work around a clang-cl devirtualization bug. (patchset #2 id:20001 of https://codereview.chromium.org/1949653002/ )
Reason for revert:
We fixed the compiler bug, this should no longer be needed.
Original issue's description:
> Work around a clang-cl devirtualization bug.
>
> clang-cl currently miscompiles calls to virtual methods of base classes
> of a final class. Since the type is final, it tries to devirtualize the call,
> but then it forgets to apply the right this adjustment.
>
> https://codereview.chromium.org/1938853002 added static_casts to a super class
> for visibility reasons, exposing this bug.
>
> BUG=608705
> R=rouslan@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/9306e66e5e680801132688b987fe850f1bb43b7a
TBR=rouslan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=608705
Committed: https://crrev.com/c19da3c46af754416c299b6dacf2223f402b1b34
Cr-Commit-Position: refs/heads/master@{#392371}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 11 (4 generated)
|