Source/core/html/HTMLOptionsCollection.cpp - Issue 195813003: Use new is*Element() helper functions further more in HTML code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.cpp

Issue 195813003: Use new is*Element() helper functions further more in HTML code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix bad assertion Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionsCollection.cpp

diff --git a/Source/core/html/HTMLOptionsCollection.cpp b/Source/core/html/HTMLOptionsCollection.cpp

index 7011248762e2e1433646c0fc4a2a8fdf93fe05b5..d1abb1d3c23f1a98665710f3e1f94e168b1186e2 100644

--- a/Source/core/html/HTMLOptionsCollection.cpp

+++ b/Source/core/html/HTMLOptionsCollection.cpp

@@ -34,7 +34,7 @@ namespace WebCore {

HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select)

: HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter)

{

- ASSERT(select.hasTagName(HTMLNames::selectTag));

+ ASSERT(isHTMLSelectElement(select));

ScriptWrappable::init(this);

}