Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/core/html/HTMLOptionsCollection.cpp

Issue 195813003: Use new is*Element() helper functions further more in HTML code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix bad assertion Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2011, 2012 Apple Computer, Inc. 2 * Copyright (C) 2006, 2011, 2012 Apple Computer, Inc.
3 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 3 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 16 matching lines...) Expand all
27 #include "core/dom/ExceptionCode.h" 27 #include "core/dom/ExceptionCode.h"
28 #include "core/dom/NamedNodesCollection.h" 28 #include "core/dom/NamedNodesCollection.h"
29 #include "core/html/HTMLOptionElement.h" 29 #include "core/html/HTMLOptionElement.h"
30 #include "core/html/HTMLSelectElement.h" 30 #include "core/html/HTMLSelectElement.h"
31 31
32 namespace WebCore { 32 namespace WebCore {
33 33
34 HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select) 34 HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select)
35 : HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter) 35 : HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter)
36 { 36 {
37 ASSERT(select.hasTagName(HTMLNames::selectTag)); 37 ASSERT(isHTMLSelectElement(select));
38 ScriptWrappable::init(this); 38 ScriptWrappable::init(this);
39 } 39 }
40 40
41 void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names) 41 void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names)
42 { 42 {
43 // As per http://www.whatwg.org/specs/web-apps/current-work/multipage/common -dom-interfaces.html#htmloptionscollection: 43 // As per http://www.whatwg.org/specs/web-apps/current-work/multipage/common -dom-interfaces.html#htmloptionscollection:
44 // The supported property names consist of the non-empty values of all the i d and name attributes of all the elements 44 // The supported property names consist of the non-empty values of all the i d and name attributes of all the elements
45 // represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its 45 // represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its
46 // name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry. 46 // name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry.
47 HashSet<AtomicString> existingNames; 47 HashSet<AtomicString> existingNames;
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 if (!value) { // undefined or null 148 if (!value) { // undefined or null
149 base.remove(index); 149 base.remove(index);
150 return true; 150 return true;
151 } 151 }
152 base.setOption(index, value.get(), exceptionState); 152 base.setOption(index, value.get(), exceptionState);
153 return true; 153 return true;
154 } 154 }
155 155
156 } //namespace 156 } //namespace
157 157
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698