Issue 1958083002: Certificate Transparency: Fix Pilot log ID comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1958083002: Certificate Transparency: Fix Pilot log ID comparison. (Closed)

Created:
4 years, 7 months ago by rmcilroy

Modified:
4 years, 7 months ago

Reviewers:
Eran Messeri

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Certificate Transparency: Fix Pilot log ID comparison. Only 32 bytes of the Log ID should be compared, not the trailing null. BUG=608787 Review-Url: https://codereview.chromium.org/1950463002 Cr-Commit-Position: refs/heads/master@{#391480} (cherry picked from commit 2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96) R=eranm@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/381067e58d5ec3cb1ffb1cec42422ebc0b605524

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/cert/sth_distributor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

rmcilroy

4 years, 7 months ago (2016-05-09 10:00:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
381067e58d5ec3cb1ffb1cec42422ebc0b605524.