Certificate Transparency: Fix Pilot log ID comparison.

Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787
Committed: https://crrev.com/2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96
Cr-Commit-Position: refs/heads/master@{#391480}

[Eran Messeri, 2016-05-03 16:43:09]

Description was changed from

==========
Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787
==========

to

==========
Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787
==========

[Eran Messeri, 2016-05-03 16:43:09]

eranm@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-05-03 16:51:57]

LGTM, but this is exactly why I don't like the approach the CT code takes for
declaring byte strings as char, rather than storing as uint8_t and casting when
needing to use string routines.

[Eran Messeri, 2016-05-04 10:07:57]

On 2016/05/03 16:51:57, Ryan Sleevi wrote:
> LGTM, but this is exactly why I don't like the approach the CT code takes for
> declaring byte strings as char, rather than storing as uint8_t and casting
when
> needing to use string routines.

Understood - I'll submit it (want the fix in ASAP) and will switch to uint8_t.

[Eran Messeri, 2016-05-04 10:12:15]

The CQ bit was checked by eranm@chromium.org

[commit-bot: I haz the power, 2016-05-04 10:12:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950463002/1

[commit-bot: I haz the power, 2016-05-04 11:22:53]

Description was changed from

==========
Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787
==========

to

==========
Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787
==========

[commit-bot: I haz the power, 2016-05-04 11:22:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-04 11:24:14]

Description was changed from

==========
Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787
==========

to

==========
Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG=608787

Committed: https://crrev.com/2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96
Cr-Commit-Position: refs/heads/master@{#391480}
==========

[commit-bot: I haz the power, 2016-05-04 11:24:15]

Patchset 1 (id:??) landed as
https://crrev.com/2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96
Cr-Commit-Position: refs/heads/master@{#391480}