Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1389633002: [Android] remove dots from log tags (Closed)

Created:
5 years, 2 months ago by dgn
Modified:
5 years, 2 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, toyoshim+midi_chromium.org, yfriedman+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] remove dots from log tags That causes tags to be elided in crash reports. This patch replaces the dots by '_'. The 'cr.' prefix is also removed as it is unnecessary now. BUG=533072 Committed: https://crrev.com/4fd7bf6592aa475c599725f6eec25ffe8a90f714 Cr-Commit-Position: refs/heads/master@{#353992}

Patch Set 1 #

Patch Set 2 : Rebase, fix same in AccountManagerHelper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M base/android/java/src/org/chromium/base/multidex/ChromiumMultiDex.java View 1 chunk +1 line, -1 line 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 1 chunk +1 line, -1 line 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncDocumentLauncher.java View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/java/src/org/chromium/media/midi/MidiOutputPortAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/BaseTestServer.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
dgn
yhirano@chromium.org: Please review changes in MidiOutputPortAndroid.java rsleevi@chromium.org: Please review changes in BaseTestServer.java yfriedman@chromium.org: Please review ...
5 years, 2 months ago (2015-10-05 11:35:56 UTC) #2
Yaron
lgtm
5 years, 2 months ago (2015-10-05 14:21:13 UTC) #3
yhirano
media/midi lgtm
5 years, 2 months ago (2015-10-05 15:41:03 UTC) #4
dgn
phajdan.jr@: PTAL at the change in BaseTestServer.java It's just about renaming the log tag.
5 years, 2 months ago (2015-10-14 09:24:25 UTC) #6
Paweł Hajdan Jr.
LGTM
5 years, 2 months ago (2015-10-14 09:42:47 UTC) #7
dgn
On 2015/10/14 09:42:47, Paweł Hajdan Jr. wrote: > LGTM Thanks!
5 years, 2 months ago (2015-10-14 09:43:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389633002/20001
5 years, 2 months ago (2015-10-14 09:44:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 10:29:58 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 10:30:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fd7bf6592aa475c599725f6eec25ffe8a90f714
Cr-Commit-Position: refs/heads/master@{#353992}

Powered by Google App Engine
This is Rietveld 408576698