Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1957703002: This CL logs the metrics to see the impact of document.write script blocking feature. The metrics a… (Closed)

Created:
4 years, 7 months ago by jkarlin
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, Yoav Weiss, tyoshino+watch_chromium.org, loading-reviews+metrics_chromium.org, blink-reviews-api_chromium.org, csharrison+watch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, blink-reviews, Nate Chapin, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

This CL logs the metrics to see the impact of document.write script blocking feature. The metrics are specifically for pages that have a blockable document.written script. The CL also has a metric to count the number of reloads for such pages to check if there is any increase in number of reloads possibly implying page breaks. BUG=603152 Review-Url: https://codereview.chromium.org/1918373002 Cr-Commit-Position: refs/heads/master@{#391526} (cherry picked from commit e6340ed747c7d4dbeedff9c963b6bd27825dd03d) BUG=603152 Committed: https://chromium.googlesource.com/chromium/src/+/373eee852ecbc50c9421f464133a4b0e0b93419e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -31 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 4 chunks +104 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc View 2 chunks +75 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A chrome/test/data/page_load_metrics/document_write_async_script.html View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/page_load_metrics/document_write_script_block.html View 1 chunk +13 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/page_load_metrics_util.h View 1 chunk +8 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/page_load_metrics_util.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +21 lines, -14 lines 0 comments Download
M third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkarlin
4 years, 7 months ago (2016-05-06 17:35:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
373eee852ecbc50c9421f464133a4b0e0b93419e.

Powered by Google App Engine
This is Rietveld 408576698