| Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
|
| diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
|
| index 9c57d493312826e26988e0f10773b4fdac83fb22..fa50c46cb8bf681c522cb4d43c2935db1290cf35 100644
|
| --- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
|
| +++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
|
| @@ -14,14 +14,20 @@ class DocumentWritePageLoadMetricsObserverTest
|
| tracker->AddObserver(
|
| make_scoped_ptr(new DocumentWritePageLoadMetricsObserver()));
|
| }
|
| - void AssertNoHistogramsLogged() {
|
| + void AssertNoPreloadHistogramsLogged() {
|
| histogram_tester().ExpectTotalCount(
|
| internal::kHistogramDocWriteParseStartToFirstContentfulPaint, 0);
|
| }
|
| +
|
| + void AssertNoBlockHistogramsLogged() {
|
| + histogram_tester().ExpectTotalCount(
|
| + internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
|
| + }
|
| };
|
|
|
| TEST_F(DocumentWritePageLoadMetricsObserverTest, NoMetrics) {
|
| - AssertNoHistogramsLogged();
|
| + AssertNoPreloadHistogramsLogged();
|
| + AssertNoBlockHistogramsLogged();
|
| }
|
|
|
| TEST_F(DocumentWritePageLoadMetricsObserverTest, PossiblePreload) {
|
| @@ -59,5 +65,71 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, NoPossiblePreload) {
|
| SimulateTimingAndMetadataUpdate(timing, metadata);
|
|
|
| NavigateAndCommit(GURL("https://www.example.com"));
|
| - AssertNoHistogramsLogged();
|
| + AssertNoPreloadHistogramsLogged();
|
| +}
|
| +
|
| +TEST_F(DocumentWritePageLoadMetricsObserverTest, PossibleBlock) {
|
| + base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);
|
| + page_load_metrics::PageLoadTiming timing;
|
| + timing.navigation_start = base::Time::FromDoubleT(1);
|
| + timing.first_contentful_paint = contentful_paint;
|
| + timing.parse_start = base::TimeDelta::FromMilliseconds(1);
|
| + PopulateRequiredTimingFields(&timing);
|
| +
|
| + page_load_metrics::PageLoadMetadata metadata;
|
| + metadata.behavior_flags |=
|
| + blink::WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteBlock;
|
| + NavigateAndCommit(GURL("https://www.google.com"));
|
| + SimulateTimingAndMetadataUpdate(timing, metadata);
|
| +
|
| + NavigateAndCommit(GURL("https://www.example.com"));
|
| +
|
| + histogram_tester().ExpectTotalCount(
|
| + internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
|
| + histogram_tester().ExpectBucketCount(
|
| + internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint,
|
| + contentful_paint.InMilliseconds(), 1);
|
| +}
|
| +
|
| +TEST_F(DocumentWritePageLoadMetricsObserverTest, PossibleBlockReload) {
|
| + base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);
|
| + page_load_metrics::PageLoadTiming timing;
|
| + timing.navigation_start = base::Time::FromDoubleT(1);
|
| + timing.first_contentful_paint = contentful_paint;
|
| + timing.parse_start = base::TimeDelta::FromMilliseconds(1);
|
| + PopulateRequiredTimingFields(&timing);
|
| +
|
| + page_load_metrics::PageLoadMetadata metadata;
|
| + metadata.behavior_flags |=
|
| + blink::WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteBlockReload;
|
| + NavigateAndCommit(GURL("https://www.google.com"));
|
| + SimulateTimingAndMetadataUpdate(timing, metadata);
|
| +
|
| + NavigateAndCommit(GURL("https://www.example.com"));
|
| +
|
| + histogram_tester().ExpectTotalCount(
|
| + internal::kHistogramDocWriteBlockReloadCount, 1);
|
| +
|
| + // Another reload.
|
| + NavigateAndCommit(GURL("https://www.google.com"));
|
| + SimulateTimingAndMetadataUpdate(timing, metadata);
|
| + NavigateAndCommit(GURL("https://www.example.com"));
|
| +
|
| + histogram_tester().ExpectTotalCount(
|
| + internal::kHistogramDocWriteBlockReloadCount, 2);
|
| +}
|
| +
|
| +TEST_F(DocumentWritePageLoadMetricsObserverTest, NoPossibleBlock) {
|
| + base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);
|
| + page_load_metrics::PageLoadTiming timing;
|
| + timing.navigation_start = base::Time::FromDoubleT(1);
|
| + timing.first_contentful_paint = contentful_paint;
|
| + PopulateRequiredTimingFields(&timing);
|
| +
|
| + page_load_metrics::PageLoadMetadata metadata;
|
| + NavigateAndCommit(GURL("https://www.google.com"));
|
| + SimulateTimingAndMetadataUpdate(timing, metadata);
|
| +
|
| + NavigateAndCommit(GURL("https://www.example.com"));
|
| + AssertNoBlockHistogramsLogged();
|
| }
|
|
|