Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 1957593003: Simplify PROGRESS shadow elements. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify PROGRESS shadow elements. This CL removes the following elements, and use ProgressShadowElement instead. - ProgressInnerElement - ProgressBarElement - ProgressValueElement The difference between ProgressInnerElement and ProgressShadowElement was only openShadowRoot() check in layoutObjectIsNeeded(). The check is unnecessary now because PROGRESS element can't have an open ShadowRoot. ProgressBarElement and ProgressShadowElement were identical. The difference between ProgressValueElement and ProgressShadowElement was only setWidthPercentage(). The function is moved to HTMLProgressElement. This CL has no behavior changes. BUG=609687 Committed: https://crrev.com/a21d40e8c4fddd9af8180dfa968794d6a9350eae Cr-Commit-Position: refs/heads/master@{#392028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -72 lines) Patch
M third_party/WebKit/Source/core/html/HTMLProgressElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLProgressElement.cpp View 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.h View 1 chunk +3 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp View 2 chunks +2 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
kochi@, would you review this please?
4 years, 7 months ago (2016-05-06 08:57:38 UTC) #3
kochi
lgtm
4 years, 7 months ago (2016-05-06 10:01:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957593003/1
4 years, 7 months ago (2016-05-06 10:12:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 10:17:09 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 10:18:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a21d40e8c4fddd9af8180dfa968794d6a9350eae
Cr-Commit-Position: refs/heads/master@{#392028}

Powered by Google App Engine
This is Rietveld 408576698