Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

Issue 1957593003: Simplify PROGRESS shadow elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp b/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
index 2c59b386926f8d4be9e1c4aa9733d6cffb43454e..1b6f5d5686b4ab61741a2a69205ff17b2fdbf6aa 100644
--- a/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
@@ -135,7 +135,7 @@ bool HTMLProgressElement::isDeterminate() const
void HTMLProgressElement::didElementStateChange()
{
- m_value->setWidthPercentage(position() * 100);
+ setValueWidthPercentage(position() * 100);
if (LayoutProgressItem layoutItem = LayoutProgressItem(layoutProgress()))
layoutItem.updateFromElement();
}
@@ -144,16 +144,15 @@ void HTMLProgressElement::didAddUserAgentShadowRoot(ShadowRoot& root)
{
ASSERT(!m_value);
- ProgressInnerElement* inner = ProgressInnerElement::create(document());
+ ProgressShadowElement* inner = ProgressShadowElement::create(document());
inner->setShadowPseudoId(AtomicString("-webkit-progress-inner-element"));
root.appendChild(inner);
- ProgressBarElement* bar = ProgressBarElement::create(document());
+ ProgressShadowElement* bar = ProgressShadowElement::create(document());
bar->setShadowPseudoId(AtomicString("-webkit-progress-bar"));
- ProgressValueElement* value = ProgressValueElement::create(document());
- m_value = value;
+ m_value = ProgressShadowElement::create(document());
m_value->setShadowPseudoId(AtomicString("-webkit-progress-value"));
- m_value->setWidthPercentage(HTMLProgressElement::IndeterminatePosition * 100);
+ setValueWidthPercentage(HTMLProgressElement::IndeterminatePosition * 100);
bar->appendChild(m_value);
inner->appendChild(bar);
@@ -170,4 +169,9 @@ DEFINE_TRACE(HTMLProgressElement)
LabelableElement::trace(visitor);
}
+void HTMLProgressElement::setValueWidthPercentage(double width) const
+{
+ m_value->setInlineStyleProperty(CSSPropertyWidth, width, CSSPrimitiveValue::UnitType::Percentage);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698