Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1957523007: Cleanly release thread-local static persistents during termination GCs. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanly release thread-local static persistents during termination GCs. Should worker termination GCs instantiate static persistent singletons while running finalizers, ensure that these are released. Also, for PersistentHeapCollectionBase<>s registered as such thread-local singletons, clear out their collection backing store along with the persistent reference when they are released. The contents and backing store of the collection should not be accessible after such a forceful release operation. R=haraken BUG= NOTRY=true Committed: https://crrev.com/51f831d6eb82a0c2de51c92c0d7bfcfcee428063 Cr-Commit-Position: refs/heads/master@{#392263}

Patch Set 1 #

Patch Set 2 : improve unit tests #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/Handle.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 2 chunks +76 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
sof
please take a look. https://codereview.chromium.org/1914233006/ stressing thread-local singleton handling in unexpected ways.
4 years, 7 months ago (2016-05-07 06:10:01 UTC) #3
haraken
Well spotted -- LGTM.
4 years, 7 months ago (2016-05-07 09:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523007/40001
4 years, 7 months ago (2016-05-07 12:34:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223842)
4 years, 7 months ago (2016-05-07 14:14:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523007/40001
4 years, 7 months ago (2016-05-07 14:33:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523007/40001
4 years, 7 months ago (2016-05-07 14:34:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223847)
4 years, 7 months ago (2016-05-07 15:08:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523007/40001
4 years, 7 months ago (2016-05-07 16:14:27 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-07 16:17:46 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 16:19:28 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51f831d6eb82a0c2de51c92c0d7bfcfcee428063
Cr-Commit-Position: refs/heads/master@{#392263}

Powered by Google App Engine
This is Rietveld 408576698