third_party/WebKit/Source/platform/heap/Handle.h - Issue 1957523007: Cleanly release thread-local static persistents during termination GCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Handle.h

Issue 1957523007: Cleanly release thread-local static persistents during termination GCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/Handle.h

diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h

index a82c488d74dca7d0c326c9b4c6fc5a5b10b807a8..0e62b436e1f4e4228ee788a3ae7a6db0cab1ddcb 100644

--- a/third_party/WebKit/Source/platform/heap/Handle.h

+++ b/third_party/WebKit/Source/platform/heap/Handle.h

@@ -549,7 +549,9 @@ private:

// released during ThreadState shutdown, clearing the association.

static void clearPersistentNode(void *self)

{

- (reinterpret_cast<PersistentHeapCollectionBase<Collection>*>(self))->uninitialize();

+ PersistentHeapCollectionBase<Collection>* collection = (reinterpret_cast<PersistentHeapCollectionBase<Collection>*>(self));

+ collection->uninitialize();

+ collection->clear();

}

NO_LAZY_SWEEP_SANITIZE_ADDRESS

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/HeapTest.cpp » ('j') | no next file with comments »