Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6599)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 1957523005: clang/win/gn: Actually build 32-bit .obj files in 32-bit builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: different Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index 3c51be189225b0bdada8289d48d45ef3010db248..02f63f17fd28daf66cc92b1d7bc9fc7cd1b1d7e8 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -10,15 +10,8 @@ import("//third_party/icu/config.gni")
import("//ui/base/ui_features.gni")
config("mini_installer_compiler_flags") {
- cflags = [
- "/bigobj",
- "/Gy", # Enable function-level linking.
- "/GS-", # Disable buffer security checking.
- "/FS", # Preserve previous PDB behavior.
- ]
-
- cflags_c = [ "/TC" ]
- cflags_cc = [ "/TP" ]
+ # Disable buffer security checking.
+ cflags = [ "/GS-" ]
}
source_set("lib") {
@@ -43,7 +36,6 @@ source_set("lib") {
"regkey.h",
]
- configs -= [ "//build/config/compiler:compiler" ]
configs += [ ":mini_installer_compiler_flags" ]
deps = [
@@ -178,7 +170,6 @@ executable("mini_installer") {
# specify our own to keep the size down.
configs -= [
"//build/config:executable_config",
- "//build/config/compiler:compiler",
"//build/config/win:console",
]
configs += [
« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698