build/config/win/BUILD.gn - Issue 1957523005: clang/win/gn: Actually build 32-bit .obj files in 32-bit builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 1957523005: clang/win/gn: Actually build 32-bit .obj files in 32-bit builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: different Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index 8b40bd452c6ee75e4efdce2db04dc6eff971e69f..d2dc8869adfa7ce4e2c42eb661df75d9282069b3 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -40,10 +40,6 @@ config("compiler") {

# and unsupported but very handy.

"/d2FastFail",

]

- if (!is_clang) {

- # TODO(thakis): Enable this with clang too, https://crbug.com/598767

- cflags += [ "/GS" ] # Enable buffer security checking.

- }

# Force C/C++ mode for the given GN detected file type. This is necessary

# for precompiled headers where the same source file is compiled in both

« no previous file with comments | « no previous file | chrome/installer/mini_installer/BUILD.gn » ('j') | no next file with comments »