Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957493003: [Findit] Make sure two consecutive suspects are included in the same sub-range. (Closed)

Created:
4 years, 7 months ago by stgao
Modified:
4 years, 7 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Findit] Make sure two consecutive suspects are included in the same sub-range. BUG=609598 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300459

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M scripts/slave/recipes/findit/chromium/compile.py View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
stgao
ptal
4 years, 7 months ago (2016-05-05 21:56:48 UTC) #2
chanli
On 2016/05/05 21:56:48, stgao wrote: > ptal lgtm.
4 years, 7 months ago (2016-05-05 22:00:22 UTC) #3
chanli
https://codereview.chromium.org/1957493003/diff/1/scripts/slave/recipes/findit/chromium/compile.py File scripts/slave/recipes/findit/chromium/compile.py (right): https://codereview.chromium.org/1957493003/diff/1/scripts/slave/recipes/findit/chromium/compile.py#newcode171 scripts/slave/recipes/findit/chromium/compile.py:171: # If two suspected revisions are consecutive, make them ...
4 years, 7 months ago (2016-05-05 22:07:06 UTC) #4
stgao
https://codereview.chromium.org/1957493003/diff/1/scripts/slave/recipes/findit/chromium/compile.py File scripts/slave/recipes/findit/chromium/compile.py (right): https://codereview.chromium.org/1957493003/diff/1/scripts/slave/recipes/findit/chromium/compile.py#newcode171 scripts/slave/recipes/findit/chromium/compile.py:171: # If two suspected revisions are consecutive, make them ...
4 years, 7 months ago (2016-05-05 22:16:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957493003/20001
4 years, 7 months ago (2016-05-05 22:16:45 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 22:21:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300459

Powered by Google App Engine
This is Rietveld 408576698