Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 1957493003: [Findit] Make sure two consecutive suspects are included in the same sub-range. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Fix nits. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/findit/chromium/compile.py
diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py
index ac64257cf7936ba527d8380e8760ecc3621ace2e..b5e5745c4cc11239875cefcb5a6aef37630ef0af 100644
--- a/scripts/slave/recipes/findit/chromium/compile.py
+++ b/scripts/slave/recipes/findit/chromium/compile.py
@@ -168,6 +168,11 @@ def RunSteps(api, target_mastername, target_buildername,
all_revisions.index(r)
for r in set(suspected_revisions) if r in all_revisions]
if suspected_revision_index:
+ # For consecutive suspected revisions, make them all in the same sub-range
+ # by removing the newer revisions, but keep the oldest one.
+ suspected_revision_index = [i for i in suspected_revision_index
+ if i - 1 not in suspected_revision_index]
+
sub_ranges = []
remaining_revisions = all_revisions[:]
for index in sorted(suspected_revision_index, reverse=True):
@@ -452,7 +457,7 @@ def GenTests(api):
)
# Entire regression range: (r1, r6]
- # Suspected_revisions: [r4]
+ # Suspected_revisions: [r4, r5]
# Expected smaller ranges: [r3, [r4, r5, r6]], [None, [r2]]
# Actual culprit: r3
# Should only run compile on r3, and then r2.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698