Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3235)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.cc

Issue 1957483003: Removal of SignedCertificateTimestampStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated a comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/chrome/browser/ssl/chrome_security_state_model_client.cc
index 412b89f3d547af090a0b9c59db8b1fdb7b13c9d1..0e92db055d80f3f0ca6b092a223b87f16b5e4478 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client.cc
@@ -110,8 +110,12 @@ void ChromeSecurityStateModelClient::GetVisibleSecurityState(
state->connection_status = ssl.connection_status;
state->security_bits = ssl.security_bits;
state->sct_verify_statuses.clear();
- for (const auto& sct : ssl.signed_certificate_timestamp_ids)
- state->sct_verify_statuses.push_back(sct.status);
+ state->sct_verify_statuses.insert(state->sct_verify_statuses.end(),
+ ssl.num_unknown_scts, net::ct::SCT_STATUS_LOG_UNKNOWN);
Charlie Reis 2016/05/11 22:30:23 nit: Wrong indent. Please run git cl format, whic
dwaxweiler 2016/05/12 07:28:16 Acknowledged.
+ state->sct_verify_statuses.insert(state->sct_verify_statuses.end(),
+ ssl.num_invalid_scts, net::ct::SCT_STATUS_INVALID);
+ state->sct_verify_statuses.insert(state->sct_verify_statuses.end(),
+ ssl.num_valid_scts, net::ct::SCT_STATUS_OK);
state->displayed_mixed_content =
(ssl.content_status & content::SSLStatus::DISPLAYED_INSECURE_CONTENT)
? true

Powered by Google App Engine
This is Rietveld 408576698