Removal of SignedCertificateTimestampStore

content/browser/loader/resource_dispatcher_host_impl.cc

Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index e594cb76d5aef0b6545234d41d7bfa1bb0eee8c1..d9597adf70950edefdbbdccdcce7291bedf08425 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -1576,7 +1576,7 @@ void ResourceDispatcherHostImpl::BeginRequest(
       request_data.enable_load_timing, request_data.enable_upload_progress,
       do_not_prompt_for_login, request_data.referrer_policy,
       request_data.visiblity_state, resource_context, filter_->GetWeakPtr(),
-      report_raw_headers, !is_sync_load,
+      report_raw_headers, report_raw_headers, !is_sync_load,

[Charlie Reis, 2016/05/11 22:30:23]

Why is this passed in twice?

Maybe it would be clearer to have a local send_extra_cert_info initialized to
report_raw_headers, with a comment saying why they use the same value?  (It's
not clear to me right now.)

[estark, 2016/05/12 00:16:55]

Daniel: sorry, I wasn't clear; I was suggesting this extra flag as a possibility
for the future, if it was too confusing to use ShouldReportRawHeaders(). I think
that Charlie's right that using ShouldReportRawHeaders() with a comment would
probably be more clear than introducing the second flag.

Charlie: ShouldReportRawHeaders() is set when the network panel is open (which
is what we use to populate requests in the security panel, which is where
Daniel's going to add the SCT details). I thought it might be confusing to
re-use ShouldReportRawHeaders() for the SCTs, since SCTs aren't really raw
headers, but we can probably just clear this up with a comment explaining why
we're using it.

[dwaxweiler, 2016/05/12 07:28:16]

Ah, okay, I will add a comment. Thanks for the explanation!

       IsUsingLoFi(request_data.lofi_state, delegate_, *new_request,
                   resource_context,
                   request_data.resource_type == RESOURCE_TYPE_MAIN_FRAME),
@@ -1875,6 +1875,7 @@ ResourceRequestInfoImpl* ResourceDispatcherHostImpl::CreateRequestInfo(
       context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,                                   // report_raw_headers
+      false,                                   // send_extra_certificate_info
       true,                                    // is_async
       false,                                   // is_using_lofi
       std::string());                          // original_headers
@@ -2298,6 +2299,7 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(
       blink::WebPageVisibilityStateVisible, resource_context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,  // request_data.report_raw_headers
+      false,

[Charlie Reis, 2016/05/11 22:30:23]

Please document this one like the others.

       true,   // is_async
       IsUsingLoFi(info.common_params.lofi_state, delegate_, *new_request,
                   resource_context, info.is_main_frame),