Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957343002: Register NativeBehavior from WorldImpact. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 2

Patch Set 3 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -50 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 2 3 chunks +3 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 7 chunks +30 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 1 7 chunks +58 lines, -29 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-09 14:19:51 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1957343002/diff/20001/pkg/compiler/lib/src/native/enqueue.dart File pkg/compiler/lib/src/native/enqueue.dart (right): https://codereview.chromium.org/1957343002/diff/20001/pkg/compiler/lib/src/native/enqueue.dart#newcode609 pkg/compiler/lib/src/native/enqueue.dart:609: NativeBehavior behavior = NativeBehavior.ofJsCall( nit: remove the extra ...
4 years, 7 months ago (2016-05-10 01:06:18 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as b1f2c2cd3ac27f20fde5dcc3051154154d305c30 (presubmit successful).
4 years, 7 months ago (2016-05-10 07:50:18 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-05-10 09:26:42 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1957343002/diff/20001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/1957343002/diff/20001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/enqueue.dart:609: NativeBehavior behavior =
NativeBehavior.ofJsCall(
On 2016/05/10 01:06:18, Siggi Cherem (dart-lang) wrote:
> nit: remove the extra var... possibly remove {} too :)
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698