Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: pkg/compiler/lib/src/native/enqueue.dart

Issue 1957343002: Register NativeBehavior from WorldImpact. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/native/enqueue.dart
diff --git a/pkg/compiler/lib/src/native/enqueue.dart b/pkg/compiler/lib/src/native/enqueue.dart
index c04509b33c66d309763733cb4bdd52800d0dd3c1..e15f185cbee361d1669c4b225f0fdabedc79d9f5 100644
--- a/pkg/compiler/lib/src/native/enqueue.dart
+++ b/pkg/compiler/lib/src/native/enqueue.dart
@@ -606,11 +606,8 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
*
*/
NativeBehavior resolveJsCall(Send node, ForeignResolver resolver) {
- NativeBehavior behavior = NativeBehavior.ofJsCall(
+ return NativeBehavior.ofJsCall(
node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
- // TODO(johnniwinther): Move registration to the world impact application.
- registerNativeBehavior(behavior, node);
- return behavior;
}
/**
@@ -624,11 +621,8 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
*/
NativeBehavior resolveJsEmbeddedGlobalCall(
Send node, ForeignResolver resolver) {
- NativeBehavior behavior = NativeBehavior.ofJsEmbeddedGlobalCall(
+ return NativeBehavior.ofJsEmbeddedGlobalCall(
node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
- // TODO(johnniwinther): Move registration to the world impact application.
- registerNativeBehavior(behavior, node);
- return behavior;
}
/**
@@ -641,11 +635,8 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
*
*/
NativeBehavior resolveJsBuiltinCall(Send node, ForeignResolver resolver) {
- NativeBehavior behavior = NativeBehavior.ofJsBuiltinCall(
+ return NativeBehavior.ofJsBuiltinCall(
node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
- // TODO(johnniwinther): Move registration to the world impact application.
- registerNativeBehavior(behavior, node);
- return behavior;
}
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/registry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698