Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 19572012: Revert 212230 "Create top-level separate targets for browser and..." (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 212230 "Create top-level separate targets for browser and..." Caused Linux x64 sizes to fail for reasons unclear. > Create top-level separate targets for browser and child dlls > > The general idea is that there's top level targets chrome and chrome_child, > and corresponding content_app and content_app_child that depend on only > the subtargets that should be included in the appropriate dll. > > Pull bluetooth_utils from bluetooth_device into separate common target > as it's referenced from chrome/common/extensions. > > Currently (probably) Windows-only and requires setting chrome_multiple_dll=1 > for gyp. > > Links, but Blink is still included in browser. > > Single-process mode is currently disabled when chrome_multiple_dll is set. > > Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html > generated by "python tools\win\split_link\graph_dependencies.py deps.html" > > Remove the previous hacky-er attempt at this that was named "split dll". > > TBR=jam@chromium.org > > BUG=237249, 256965 > > Review URL: https://codereview.chromium.org/17619005 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -174 lines) Patch
MM trunk/src/base/debug/trace_event.h View 3 chunks +12 lines, -0 lines 0 comments Download
M trunk/src/base/debug/trace_event_impl.cc View 3 chunks +6 lines, -0 lines 0 comments Download
MM trunk/src/base/debug/trace_event_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/build/common.gypi View 2 chunks +8 lines, -5 lines 0 comments Download
M trunk/src/chrome/app/chrome_main_delegate.cc View 4 chunks +13 lines, -41 lines 0 comments Download
M trunk/src/chrome/app/client_util.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome.gyp View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_dll.gypi View 4 chunks +14 lines, -41 lines 0 comments Download
M trunk/src/chrome/chrome_syzygy.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/installer/mini_installer_syzygy.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/chrome/split_dll_fake_entry.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM trunk/src/components/autofill.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/app/content_main_runner.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +3 lines, -7 lines 0 comments Download
MM trunk/src/content/content.gyp View 4 chunks +8 lines, -32 lines 0 comments Download
M trunk/src/content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/app/content_main_delegate.cc View 2 chunks +7 lines, -29 lines 0 comments Download
M trunk/src/ui/keyboard/keyboard.gyp View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/glue/webkitplatformsupport_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
7 years, 5 months ago (2013-07-18 04:14:28 UTC) #1
scottmg
7 years, 5 months ago (2013-07-18 04:14:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r212239.

Powered by Google App Engine
This is Rietveld 408576698