Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: trunk/src/chrome/chrome_dll.gypi

Issue 19572012: Revert 212230 "Create top-level separate targets for browser and..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/chrome_common.gypi ('k') | trunk/src/chrome/chrome_syzygy.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/chrome_dll.gypi
===================================================================
--- trunk/src/chrome/chrome_dll.gypi (revision 212238)
+++ trunk/src/chrome/chrome_dll.gypi (working copy)
@@ -21,11 +21,6 @@
],
},
}], # OS=="mac"
- ['chrome_multiple_dll==1', {
- 'dependencies': [
- 'chrome_child_dll',
- ],
- }],
['incremental_chrome_dll==1', {
# Linking to a different directory and then hardlinking back
# to OutDir is a workaround to avoid having the .ilk for
@@ -80,6 +75,8 @@
},
'dependencies': [
'<@(chromium_browser_dependencies)',
+ '<@(chromium_child_dependencies)',
+ '../content/content.gyp:content_worker',
'app/policy/cloud_policy_codegen.gyp:policy',
],
'conditions': [
@@ -224,23 +221,24 @@
'AdditionalManifestFiles': '$(ProjectDir)\\app\\chrome.dll.manifest',
},
},
- }],
- ['chrome_multiple_dll==1', {
- 'defines': [
- 'CHROME_MULTIPLE_DLL_BROWSER',
- ],
- }, {
- 'dependencies': [
- '<@(chromium_child_dependencies)',
- '../content/content.gyp:content_worker',
- ],
- }],
+ }], # OS=="win"
['OS=="mac" and component!="shared_library"', {
'includes': [ 'chrome_dll_bundle.gypi' ],
}],
['OS=="mac" and component=="shared_library"', {
'xcode_settings': { 'OTHER_LDFLAGS': [ '-Wl,-ObjC' ], },
}],
+ ['chrome_split_dll', {
+ 'sources': [
+ # See comment in .cc for explanation.
+ 'split_dll_fake_entry.cc',
+ ],
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalOptions': ['/splitlink'],
+ },
+ }
+ }],
['OS=="mac"', {
'xcode_settings': {
# Define the order of symbols within the framework. This
@@ -332,30 +330,5 @@
},
],
}],
- ['chrome_multiple_dll', {
- 'targets': [
- {
- 'target_name': 'chrome_child_dll',
- 'type': 'shared_library',
- 'product_name': 'chrome_child',
- 'variables': {
- 'enable_wexit_time_destructors': 1,
- },
- 'dependencies': [
- '<@(chromium_child_dependencies)',
- '../content/content.gyp:content_worker',
- 'policy_path_parser',
- ],
- 'defines': [
- 'CHROME_MULTIPLE_DLL_CHILD',
- ],
- 'sources': [
- 'app/chrome_main.cc',
- 'app/chrome_main_delegate.cc',
- 'app/chrome_main_delegate.h',
- ],
- }, # target chrome_child_dll
- ],
- }],
],
}
« no previous file with comments | « trunk/src/chrome/chrome_common.gypi ('k') | trunk/src/chrome/chrome_syzygy.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698