Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1957193002: Add contents / viewport heights to LayoutAnalyzer trace event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index a1a94312d644f69ddbacb36edcd8409d8d7e30a2..79505d9f45942c9e6c6d0ef7a75dfe415c71cc92 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -842,6 +842,8 @@ PassOwnPtr<TracedValue> FrameView::analyzerCounters()
OwnPtr<TracedValue> value = m_analyzer->toTracedValue();
value->setString("host", layoutView()->document().location()->host());
value->setString("frame", String::format("0x%" PRIxPTR, reinterpret_cast<uintptr_t>(m_frame.get())));
+ value->setInteger("contentsHeightAfterLayout", layoutView()->documentRect().height());
+ value->setInteger("visibleHeight", visibleHeight());
return value.release();
}
@@ -851,7 +853,7 @@ void FrameView::performLayout(bool inSubtreeLayout)
{
ASSERT(inSubtreeLayout || m_layoutSubtreeRootList.isEmpty());
- TRACE_EVENT_BEGIN0(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout");
+ TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout", "contentsHeightBeforeLayout", layoutView()->documentRect().height());
benjhayden 2016/05/09 20:00:50 newline before "contentsHeightBeforeLayout", pleas
Kunihiko Sakamoto 2016/05/10 02:12:29 Done.
prepareLayoutAnalyzer();
ScriptForbiddenScope forbidScript;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698