Issue 195713002: Fix crash on ASSERT when in subtree layout and LayoutState is not initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195713002: Fix crash on ASSERT when in subtree layout and LayoutState is not initialized (Closed)

Created:
6 years, 9 months ago by atreat

Modified:
6 years, 9 months ago

Reviewers:
eseidel

CC:
blink-reviews, esprehn, Julien - ping for review, leviw_travelin_and_unemployed, ojan

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix crash on ASSERT when in subtree layout and LayoutState is not initialized Fix crash on ASSERT when in subtree layout and LayoutState is not initialized. This was caused by r167724 which improperly assumed that FrameView::isSubtreeLayout was equivalent to the parameter inSubtreeLayout as passed to the layout methods. In fact, there are cases where inSubtreeLayout is true while FrameView::isSubtreeLayout returns false. BUG=348481 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168964

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	Source/core/frame/FrameView.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	Source/core/frame/FrameView.cpp	View		3 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/195713002/1

6 years, 9 months ago (2014-03-11 21:26:54 UTC) #3

Message was sent while issue was closed.

Change committed as 168964

Expand Messages | Collapse Messages