Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/frame/FrameView.h

Issue 195713002: Fix crash on ASSERT when in subtree layout and LayoutState is not initialized (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index 4f53c0ec638658904f20c64ec61efe9c624bfa94..648d73eef16e254526db7f8eacada2b395e00a8d 100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -304,6 +304,9 @@ public:
virtual void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) OVERRIDE;
virtual bool shouldAttemptToScrollUsingFastPath() const OVERRIDE;
+ // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter
+ // passed around the FrameView layout methods can be true while this returns
+ // false.
bool isSubtreeLayout() const { return !!m_layoutSubtreeRoot; }
protected:
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698